Use an interface instead of method reflection to call the API#523
Open
SquidDev wants to merge 1 commit intodan200:masterfrom
Open
Use an interface instead of method reflection to call the API#523SquidDev wants to merge 1 commit intodan200:masterfrom
SquidDev wants to merge 1 commit intodan200:masterfrom
Conversation
This makes it easier to verify at compile time that API methods are valid.
Lignum
approved these changes
Feb 24, 2018
Contributor
Lignum
left a comment
Lignum
left a comment
There was a problem hiding this comment.
I also think it makes the API code substantially easier to read, but that may just be me.
Not just you, this is beautiful. Looks good to me.
Definitely a much better way to do it! Though if ComputerCraft is using Java 8 then it could be made a little cleaner with |
Contributor
It could be made even cleaner on top of that using Guava's e.g. write a supplier to get an optional containing the API impl, memoize it with Guava, and then just use |
SquidDev
added a commit
to cc-tweaked/CC-Tweaked
that referenced
this pull request
Dec 10, 2018
This is originally based on dan200/ComputerCraft#523, but being more liberal in how it breaks backwards compatibility. 1.14 and all that after all. There's several reasons for this change: - Make the API code cleaner and less error prone by removing reflection. - Try to make ComputerCraft.java less monolithic by moving functionality into separate module-specific classes. - Hopefully make the core class less Minecraft dependent, meaning emulators are a little less dependent on anything outside of /core.
SquidDev
added a commit
to cc-tweaked/CC-Tweaked
that referenced
this pull request
Dec 17, 2018
This is originally based on dan200/ComputerCraft#523, but being more liberal in how it breaks backwards compatibility. 1.14 and all that after all. There's several reasons for this change: - Make the API code cleaner and less error prone by removing reflection. - Try to make ComputerCraft.java less monolithic by moving functionality into separate module-specific classes. - Hopefully make the core class less Minecraft dependent, meaning emulators are a little less dependent on anything outside of /core.
SquidDev
added a commit
to cc-tweaked/CC-Tweaked
that referenced
this pull request
Dec 17, 2018
This is originally based on dan200/ComputerCraft#523, but being more liberal in how it breaks backwards compatibility. 1.14 and all that after all. There's several reasons for this change: - Make the API code cleaner and less error prone by removing reflection. - Try to make ComputerCraft.java less monolithic by moving functionality into separate module-specific classes. - Hopefully make the core class less Minecraft dependent, meaning emulators are a little less dependent on anything outside of /core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to verify at compile time that API methods are valid. I also think it makes the API code substantially easier to read, but that may just be me.