Improve vertex transformation system#492
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
Conversation
This migrates TurtleMultiModel's current vertex transformation system into something more powerful and "correct". Namely, it has the following improvements: - Handles all position formats (float, byte, etc...) - Correctly translates normals of quads - Reorders faces if the winding order is reversed
Every other mod has some fun feature, so should we. And yes, this was worth the 400 lines it took to implement.
SquidDev
force-pushed
the
feature/fun-turtle-rendering
branch
from
35da605 to
82f49e9
Compare
|
Can one of the admins verify this patch? |
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…fun-turtle-rendering Improve vertex transformation system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates
TurtleMultiModel's current vertex transformation system into something more powerful and "correct". Namely, it has the following improvements:This also improves how particular turtles are rendered, as everyone needs some joy in their life.