Add simple JEI integration#482
Open
SquidDev wants to merge 1 commit intodan200:masterfrom
Open
Conversation
- Ensure pocket computers and turtles are distinguished by upgrades and computer family. - Ensure disks are distinguished by colour. - Hide treasure disks from the list
|
Can one of the admins verify this patch? |
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…jei-integration Add simple JEI integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that mod integration is something that ComputerCraft normally steers clear of, but JEI is sufficiently ubiquitous that this is probably worth it.
JEI compares items simply by item name and damage value, ignoring NBT. This means many recipes do not function correctly. For instance, viewing the recipe of a Melee Turtle will display all upgrade recipes. This PR fixes this:
Note that this doesn't add anything "fancy", such as recipe handlers for turtle and pocket upgrades. This might be worth considering in the future.