[WIP] Only instantiate ServerComputer on tile ticks#454
Open
SquidDev wants to merge 2 commits intodan200:masterfrom
Open
[WIP] Only instantiate ServerComputer on tile ticks#454SquidDev wants to merge 2 commits intodan200:masterfrom
SquidDev wants to merge 2 commits intodan200:masterfrom
Conversation
Instead we create a ComputerProxy, which delegates methods to the ServerComputer or TileComputerBase, depending on which one exists.
SquidDev
force-pushed
the
hotfix/lazy-computer-peripheral
branch
from
fbbfe33 to
245085f
Compare
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…azy-computer-peripheral [WIP] Only instantiate ServerComputer on tile ticks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a couple of the solutions proposed in #409 and #442. There are a couple of things to note:
.getID()when the computer has no id will not allocate one. This is a regression from current behaviour, so it's worth discussing what the appropriate behaviour should be. This is pretty rare (it'll only ever happen within the first tick of a computer being placed), but should still be considered.I'll remove the WIP mark once I've resolved the last point.