Merge Vanara Jñāna v1.2661 Release Candidate#16
Conversation
Remove AppSDK packages
Add `Vanara.Core` v4.2.1
Add `AppStyles.xaml`
Overhaul `FileExplorerPage`
Add `IShellItemModel`, `IShellFolderModel`, `ShellItemModel`
Add Service Contracts
Add `SettingsPage`, `WebViewPage` Overhaul namespaces
Pull and merge current version
Overhaul WinUi 3 folder structure. Create `README.md`
Add Build script `build.yml`. Update `README.md`
tajbender
left a comment
There was a problem hiding this comment.
I've tested the debug Releases.
- Windows 11 Insider
- Packages as seen in project file
To-Dos / Things to come
SettingsService- i18n
- Themes
- Navigation with History
- Serialization
| <Using Include="System.Runtime.InteropServices.ComTypes.FILETIME" Alias="FILETIME"/> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <!-- <ItemGroup> |
There was a problem hiding this comment.
Please undo this change before I merge. The analyzers are part of what I'm testing with this solution.
There was a problem hiding this comment.
Sorry, my fault. was not intended...
| <PackageVersion Include="Vanara.BITS" Version="$(VanaraVer)" /> | ||
| <PackageVersion Include="Vanara.CodeGen" Version="$(VanaraVer)" /> | ||
| <PackageVersion Include="Vanara.Core" Version="$(VanaraVer)" /> | ||
| <PackageVersion Include="Vanara.Core" Version="4.2.1" /> |
There was a problem hiding this comment.
Vanara.Core needs to be the same version as all the other Vanara libraries. Please remove this change before I merge.
There was a problem hiding this comment.
Sorry, my fault. was not intended...
There was a problem hiding this comment.
...current config:
<PackageReference Include="Vanara.Core" Version="5.0.5" />
<PackageReference Include="Vanara.PInvoke.Shell32" Version="5.0.5" />
<PackageReference Include="Vanara.PInvoke.User32" Version="5.0.5" />
<PackageReference Include="Vanara.Windows.Shell" Version="5.0.5" />
There was a problem hiding this comment.
This file cannot be removed -- it is the solution file.
There was a problem hiding this comment.
Sorry, my fault. was not intended... 😁
There was a problem hiding this comment.
Is this file needed for your project? I'm ok leaving it, but it will then build on github after each commit.
There was a problem hiding this comment.
No, it is NOT needed. The solution actually not even has Deployment Descriptors.
It would be nice you could integrate Jnana's solution into the whole package.
Especially, since I can't build most of the ClassicSamples yet with that old base main branch this Repo is based on.
|
There is a newer build for the current state of Vanara Jnana: https://github.com/tajbender/WinClassicSamplesCS/tree/ReleaseCandidate I still have to rewire many things, especially the ViewModels. In fact, there is no functionality yet. I just wanted to make sure you can see what is coming there as soon as possible. Feel free to edit and adopt as you need, it's been a while a have merged into other's Repositories 🦆 |
|
I also would like you to check for a bug - 🐛 It crashes when exiting ...can you confirm that on your machine? I guess it is some kind of package conflict, or my project files are messed - both are possible and likely 😈 Thanks for your patience. |
|
|
@dahall the projection dll should be removed. However, I don't know where it's reference comes from. 💭
|

Merge
Vanara Jñānav1.2661 Release Candidate