feat: add support for k0s - #124
Conversation
|
Thanks for the PR! Looks good on a first skim, I'll validate this later and do a full review. Eventually it would be very nice if we had some way to validate the installer in e2e tests for all the different distros. But no need for you to add anything for now, I'll give this a try at some point later. |
|
Yes, also I was thinking also maybe we should have different file like distros/generic distros/k0s etc... so we can add more with time. I wanted to add for https://github.com/portainer/kubesolo, but i want to see for this PR first. |
|
@ctrox can you allow builds for this so I can test? |
I approved the checks and also pushed the branch myself as PRs can't trigger image pushes (would be a bit problematic if they could). |
|
I just tested this, when the manager started up it crashed out failing to find PEM data in the certificate input. UPDATE: scratch that, I'd deployed it in the wrong namespace and it always expects zeropod-system and I'd deployed it in zeropod |
ctrox
left a comment
There was a problem hiding this comment.
Tested the installer on a fresh k0s cluster, nice work! Just a few comments regarding the path handling which could be simplified.
| containerdv1AlreadyConfigured = fullContainerdConfigV2 + runtimeConfig + ` | ||
| ) | ||
|
|
||
| var containerdv1AlreadyConfigured = fullContainerdConfigV2 + fmt.Sprintf(runtimeConfig, strings.TrimSuffix(defaultOptPath, "/"), true) + ` |
There was a problem hiding this comment.
any reason this can't be in the existing var block?
There was a problem hiding this comment.
It cannot be a const since it uses fmt.Sprintf. Main has the same line now anyway, happy to move it into the test func if you prefer.
|
Will address the changes :) |
Oh would be nice if that would work out of the box. Created #127 to address this. |
|
Hi @eznix86 @ctrox , I have a PR waiting, that is integrating microk8s (#128) with a second branch with big documentation updates (kybernate#2) - still in progress. As there are some overlapping changes on the installer/main.go (seems like me and @eznix86 are using the same code agent ;-), I'd like to integrate the k0s integration into my merge (if it is ok) and in the same time, add the regarding k0s runtime documentation (following my current first draft). I want to go on with development, adding cuda checkpointing support (as I need this for a different project I want to work on), but I want to avoid forking zeropd and have them diverging from each other. |
|
Sorry for the late reply, made some changes! |
fixes #122