Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

modified deployment for using cloud shell#8

Open
bsherwin wants to merge 2 commits into
mainfrom
brsherwi/cloudshell
Open

modified deployment for using cloud shell#8
bsherwin wants to merge 2 commits into
mainfrom
brsherwi/cloudshell

Conversation

@bsherwin

@bsherwin bsherwin commented Feb 7, 2024

Copy link
Copy Markdown

The purpose of this change is to encourage the user to use the Azure Cloud Shell to avoid any shell specific settings that vary between MacOS and Windows. Additionally, because the authentication has already been done to start the Cloud Shell, there is no need for the az login and az account set commands.

@bsherwin

bsherwin commented Feb 8, 2024

Copy link
Copy Markdown
Author

@ydaponte Since you deployed with this, would you mind reviewing the PR?

@ydaponte ydaponte left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you get the latest changes from Anuj's last PR - replace the name of the purview security group to "sg-pview-fabric-scan" instead of "sg-purview-fabric-scan." on Deployment.md last section. And rebranding from AAD to Entra ID.

@bsherwin

bsherwin commented Feb 9, 2024

Copy link
Copy Markdown
Author

@ydaponte - I merged Anuj's changes.

@bsherwin bsherwin requested a review from ydaponte February 9, 2024 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants