fix: remove deprecated request package to fix critical form-data vulnerability#9531
Closed
fix: remove deprecated request package to fix critical form-data vulnerability#9531
Conversation
…erability The deprecated `request` package was listed as a direct dependency in both `core/package.json` and `extensions/vscode/package.json`, but was never actually imported or used anywhere in the codebase. This package brought in a transitive dependency on `form-data@2.3.3` which has a Critical Severity vulnerability (SNYK-JS-FORMDATA-10841150: Predictable Value Range from Previous Values). By removing the unused `request` package and its `@types/request` type definitions, we eliminate this critical security vulnerability. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
BekahHW
requested review from
Patrick-Erichsen
and removed request for
a team
Contributor
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
3 similar comments
Contributor
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
dosubot
bot
added
the
size:XS
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated
requestpackage from the codebase to fix a Critical Severity security vulnerability.Vulnerability Details
The
requestpackage (which is deprecated and no longer maintained) was listed as a direct dependency in bothcore/package.jsonandextensions/vscode/package.json. This package brought in a transitive dependency onform-data@2.3.3which has a Critical Severity vulnerability:Investigation Findings
After scanning the codebase, I found that the
requestpackage was:grepforimport.*from.*'request'andrequire('request')returned no results)package.jsonfiles as a direct dependencyChanges Made
requestfromcore/package.json@types/requestfromcore/package.json(devDependencies)requestfromextensions/vscode/package.json@types/requestfromextensions/vscode/package.json(devDependencies)package-lock.jsonfilesVerification
After the fix, running
npx snyk testconfirms that the criticalform-datavulnerability has been eliminated from both thecoreandextensions/vscodepackages.Continue Tasks
Powered by Continue
Summary by cubic
Removed the deprecated request dependency (and types) to eliminate a critical form-data vulnerability. It was unused and only inflated the dependency tree.
Dependencies
Bug Fixes
Written for commit acab841. Summary will update on new commits.