fix(docs): escape TS JSX syntax error in get-started code block - #538
Open
hussainjamal760 wants to merge 1 commit into
Open
fix(docs): escape TS JSX syntax error in get-started code block#538hussainjamal760 wants to merge 1 commit into
hussainjamal760 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #537
What does this PR do?
This PR fixes a critical TypeScript parsing error (
TS1382) insidesrc/pages/get-started.tsxthat was causingyarn typecheckand CI builds to fail.The issue was caused by an unescaped right angle bracket (
>) inside thepodman psoutput example in a JSX<CodeBlock>. The parser misinterpreted0.0.0.0:8080->80/tcpas an unclosed HTML/JSX tag.Key Fixes:
>character by converting it into a JSX string literal expression:0.0.0.0:8080-{'>'}80/tcp.How to test
yarn typecheckin your terminal.TS1382error.yarn start, navigate tohttp://localhost:3000/get-started, and verify that thepodman pscode block displays0.0.0.0:8080->80/tcpcorrectly.