Repository navigation
Refresh README before announcing the new FetchIt features - #411
Merged
Merged
Conversation
…uctions Signed-off-by: Ryan Cook <rcook@redhat.com>
|
Sorry @cooktheryan, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 6 days and 17 hours by commenting |
Reviewer's GuideRefreshes README.md into a current, safety-conscious guide: it presents FetchIt’s new features, provides a corrected rootless quick start and non-destructive cleanup instructions, documents architecture and helper compatibility, and consolidates build, test, and documentation validation guidance. State diagram for FetchIt demonstration cleanupstateDiagram-v2
[*] --> Running
Running --> Stopped: podman stop fetchit
Stopped --> EngineRemoved: podman rm fetchit
EngineRemoved --> DemoCleaned: podman rm -f welcome
DemoCleaned --> StateRetained: keep fetchit-volume
StateRetained --> [*]
Flow diagram for the FetchIt rootless quick startflowchart LR
A[Enable rootless Podman socket] --> B[Create $HOME/.fetchit/config.yaml]
B --> C[Run FetchIt with fetchit-volume and /opt/mount]
C --> D[Reconcile welcome-to-fetchit]
D --> E[Open status or sample endpoint]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README still contains a broken /opt/config.yaml mount, a cleanup command that deletes persistent engine state, and little guidance on current features. Refresh it before publicizing the recent work.
Add an overview of Quadlet, opt-in cleanup/rollback, kube networks/labels/SOPS, mirrors, status, and multi-architecture samples. Provide one rootless quick start with the correct /opt/mount config path and verified welcome container name. Document state retention, source builds on amd64/arm64, compatible helpers, rootful/rootless scope, and unreleased-image limitations. Link to the updated guides for detailed operations.
Validation: README YAML and shell syntax, all local guide links, sample name/port cross-check, strict Sphinx build, and git diff checks passed.
Summary by Sourcery
Refresh the README with accurate quick-start instructions and comprehensive guidance for current FetchIt features and operating constraints.
Bug Fixes:
Enhancements:
Documentation: