Skip to content

make: fix benchmark target package selection - #13081

Open
Retr0-XD wants to merge 1 commit into
containerd:mainfrom
Retr0-XD:fix/make-benchmark-target
Open

make: fix benchmark target package selection#13081
Retr0-XD wants to merge 1 commit into
containerd:mainfrom
Retr0-XD:fix/make-benchmark-target

Conversation

@Retr0-XD

Copy link
Copy Markdown

Summary

Fixes #12973 by making the benchmark Make target run benchmarks across containerd packages instead of invoking go test without package arguments.

What changed

  • Makefile benchmark target now uses:
    • -run ^$ to skip normal tests while running benchmarks
    • ${PACKAGES} so go test gets explicit package arguments
  • removed -test.root, which caused root-package handling issues and immediate failure from repo root.

Reproduction

Before this change:

  • make benchmark failed immediately from repo root with:
    • .

    • no Go files in .../containerd

After this change:

  • make -n benchmark expands to go test ... ${PACKAGES}
  • make benchmark starts running package benchmarks instead of failing immediately.

Testing

  • make -n benchmark
  • make benchmark (started package benchmark execution; long-running suite interrupted locally)

@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review Mar 21, 2026
@dosubot dosubot Bot added the area/toolchain Build and Release Toolchain label Mar 21, 2026
@samuelkarp

Copy link
Copy Markdown
Member

make benchmark (started package benchmark execution; long-running suite interrupted locally)

It looks like this hasn't been tested.

@mxpv mxpv added the status/needs-update Awaiting contributor update label Jun 26, 2026
@Retr0-XD
Retr0-XD force-pushed the fix/make-benchmark-target branch from 9efbd21 to 7bcc0d3 Compare September 13, 2026 13:30
Copilot AI lite review requested due to automatic review settings September 13, 2026 13:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Signed-off-by: Retr0-XD <sakthi.harish@edgeverve.com>
@Retr0-XD
Retr0-XD force-pushed the fix/make-benchmark-target branch from 7bcc0d3 to 341a307 Compare September 13, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/toolchain Build and Release Toolchain size/XS status/needs-update Awaiting contributor update

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

make benchmark never work

5 participants