[[--DO-NOT-MERGE--]] Mock ups for fake, experimental alpha APIs.#365
Open
jdef wants to merge 7 commits intocontainer-storage-interface:masterfrom
Open
[[--DO-NOT-MERGE--]] Mock ups for fake, experimental alpha APIs.#365jdef wants to merge 7 commits intocontainer-storage-interface:masterfrom
jdef wants to merge 7 commits intocontainer-storage-interface:masterfrom
Conversation
added 7 commits
April 4, 2019 14:52
Enumerations, fields, messages, methods, and services support `alpha_xxx` designations, indicating that they are part of an experimental feature that may never evolve to "stable" status.
A new AlphaFeature message type was added for each of the plugin, controller, and node services. Experimental features supported by the SP should be advertised via one or more of the following RPCs: * Identity.GetPluginCapabilities * Controller.ControllerGetCapabilities * Node.NodeGetCapabilities
Mock up of an experimental API to support tape rotation for plugin controllers. Note the RPC as well as each of the newly added request and response types has been labeled with an `alpha_xxx` marker option.
Mock up of an experimental API to advertise volume usage in units of quarks. Note the addition of the `alpha_enum_value` marker option to the newly added enum value.
Mock up of an experimental API to communicate the data lineage of a volume. Note that the newly added field has the `alpha_field` marker option set, as well as that the newly added message has a similar alpha marker. See https://en.wikipedia.org/wiki/Data_lineage
Mock up of an experimental object storage API. Note the use of the `alpha_service` marker option for the new gRPC service, as well as the additional `alpha_xxx` markers for the new RPCs and top-level request/response messages.
saad-ali
reviewed
Apr 4, 2019
| // releases. | ||
| bool alpha_message = 1060; | ||
| } | ||
| extend google.protobuf.MethodOptions { |
Member
There was a problem hiding this comment.
Do we want to allow this?
My understanding after the call was that we allow new fields in the main spec on existing RPCs with a experimental tag. But we force new RPCs in to a separate new experimental service (potentially in a different file).
jdef
commented
Feb 24, 2020
|
|
||
| rpc ObjectStoreRead(ObjectStoreReadRequest) | ||
| returns (ObjectStoreReadResponse) { | ||
| option (alpha_method) = true; |
Member
Author
There was a problem hiding this comment.
it's arguable that marking the method as alpha is redundant because the entire service is already alpha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #355