[KIP-932] : Add tests for share consumer - 1/N#2273
Open
Kaushik Raina (k-raina) wants to merge 4 commits into
Open
[KIP-932] : Add tests for share consumer - 1/N#2273Kaushik Raina (k-raina) wants to merge 4 commits into
Kaushik Raina (k-raina) wants to merge 4 commits into
Conversation
Kaushik Raina (k-raina)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
airlock-confluentinc
Bot
force-pushed
the
dev_kip-932_queues-for-kafka_add_tests_1_of_N
branch
from
e5c181a to
cb7db99
Compare
Pratyush Ranjan (PratRanj07)
requested changes
Jun 12, 2026
Pratyush Ranjan (PratRanj07)
left a comment
Pratyush Ranjan (PratRanj07)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Kaushik Raina (@k-raina) for the PR!
In general some nits! Otherwise the tests looks good!
There is some build failure please check that
|
|
||
| assert conflicts, "second-thread access during poll() should have raised _CONFLICT" | ||
| assert all(err.code() == KafkaError._CONFLICT for err in conflicts) | ||
| assert 'multi-threaded' in conflicts[0].str().lower(), f"unexpected _CONFLICT message: {conflicts[0].str()!r}" |
Contributor
There was a problem hiding this comment.
I think this shouldnt be needed, we are already asserting on the error code
| for i in range(5): | ||
| producer.produce(topic, value=f'first-{i}'.encode()) | ||
| producer.flush(timeout=10.0) | ||
| first = drain_share_consumers([sc], 5)[0] |
Contributor
There was a problem hiding this comment.
Better naming of the returned records
| producer.produce(topic, value=f'first-{i}'.encode()) | ||
| producer.flush(timeout=10.0) | ||
| first = drain_share_consumers([sc], 5)[0] | ||
| assert sorted(m.value() for m in first) == [f'first-{i}'.encode() for i in range(5)], 'phase 1 records mismatch' |
Contributor
There was a problem hiding this comment.
Suggested change
| assert sorted(m.value() for m in first) == [f'first-{i}'.encode() for i in range(5)], 'phase 1 records mismatch' | |
| assert sorted(m.value() for msg in first) == [f'first-{i}'.encode() for i in range(5)], 'phase 1 records mismatch' |
| producer.produce(topic, value=b'v', timestamp=ts) | ||
| producer.flush(timeout=10.0) | ||
|
|
||
| received = drain_share_consumers([sc], 1)[0] |
Contributor
There was a problem hiding this comment.
Suggested change
| received = drain_share_consumers([sc], 1)[0] | |
| received_msgs = drain_share_consumers([sc], 1)[0] |
| producer.produce(topic, key=None, value=None) # null -> offset 1 | ||
| producer.flush(timeout=10.0) | ||
|
|
||
| received = drain_share_consumers([sc], 2)[0] |
Contributor
There was a problem hiding this comment.
Suggested change
| received = drain_share_consumers([sc], 2)[0] | |
| received_msgs = drain_share_consumers([sc], 2)[0] |
| producer.flush(timeout=10.0) | ||
|
|
||
| received = drain_share_consumers([sc], 2)[0] | ||
| by_offset = {m.offset(): (m.key(), m.value()) for m in received} |
Contributor
There was a problem hiding this comment.
Suggested change
| by_offset = {m.offset(): (m.key(), m.value()) for m in received} | |
| by_offset = {msg.offset(): (msg.key(), msg.value()) for msg in received} |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keys, headers, header order, timestamps, empty/null payloads, multi-partition, batch-size caps,
oversized records, compression, and rejecting cross-thread use
repeated/incremental subscribes, empty-list and bad topic names, subscribing before a topic exists,
and re-subscribing to the same topic