Open
Conversation
dpfls0922
approved these changes
Oct 23, 2024
| else if (shape instanceof Circle) { | ||
| /* 구현하세요 */ | ||
| Circle cirle = (Circle)circle; | ||
| return circle.radius*circle.radius*PI; |
Member
There was a problem hiding this comment.
정답입니다! 하지만 여기는 띄어쓰기가 안됐어요! 포맷팅
haesa
approved these changes
Oct 23, 2024
| if (shape instanceof Square) { | ||
| /* 구현하세요 */ | ||
| Square square = (Square)shape; | ||
| return square.side * square.topLeft; |
Contributor
There was a problem hiding this comment.
topLeft는 좌측 상단 좌표라고 생각해서 저는 아래처럼 작성했어요!
Suggested change
| return square.side * square.topLeft; | |
| return square.side * square.side; |
| else if (shape instanceof Circle) { | ||
| /* 구현하세요 */ | ||
| Circle cirle = (Circle)circle; | ||
| return circle.radius*circle.radius*PI; |
Contributor
There was a problem hiding this comment.
여기는 수식이 복잡하지 않아서 operator와 operand 사이를 붙여쓰지 않아도 될 것 같아요 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
정답