Skip to content

chore: remove internal reviewer labels from comments, test names and docs - #2749

Merged
colinmegill merged 2 commits into
edgefrom
chore/remove-internal-reviewer-labels
Sep 9, 2026
Merged

colinmegill merged 2 commits into
edgefrom
chore/remove-internal-reviewer-labels

Conversation

@colinmegill

Copy link
Copy Markdown
Member

Text-only cleanup, zero behaviour change: 39 files had internal reviewer/worker labels in comments, docstrings, test names, describe/test strings, and docs. They are replaced with neutral wording ("review round N", "the second reviewer", "a headless worker"). Identifier renames are confined to test-only symbols (four test functions and two constants in test_certify_strict_gate.py; one local variable and one SQL literal in projection_gate_test.py), with every reference updated.

Not touched: delphi/Dockerfile and delphi/docs/QUICK_START.md (the unrelated astral-sh package maintainer), two lockfiles (the unrelated astral-regex npm package), and one notebook whose only match is a byte sequence inside a base64 image blob.

Verification: py_compile on every edited Python file; bash -n on the two shell scripts; YAML parse of the workflow; the Clojure test file reads as well-formed forms; tsc --noEmit clean for server and cdk; test_stages 172 passed, test_polarity_property 125 passed / 3 skipped, tests/projgate 47 passed, test_certify_strict_gate 143 passed, fence tests 23 passed / 8 skipped, four server unit files 95 passed, cdk alarms tests 49 passed. Integration suites that need the full Docker stack were not run here. Second review pending.

🤖 Generated with Claude Code

https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s

colinmegill and others added 2 commits September 9, 2026 00:29
…names

Scrubs internal code-review labels from comments, docstrings, test/describe
names, and one doc reference across delphi, server, cdk, ci, math, and the
CI workflow. Neutral phrasing preserves the original meaning (e.g. "review
round N", "the second reviewer's witness", "a headless worker"). A few
test-local identifiers/constants that embedded the label were renamed and
all references updated. Comments/docstrings/strings/test names/docs only —
no behavior change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
Follow-up to the prior commit's review: replaces two manufactured,
untracked filenames introduced by the earlier sweep with neutral
descriptions of the review round instead (docs/engine-stage-oracles.md,
delphi/tests/replay_harness/test_stages.py, and
server/__tests__/unit/pcaMathTickZeroHttp.test.ts), and rewrites five
pre-existing internal host-session identifiers in delphi/docs design and
journal docs to neutral descriptions of the work session. Leaves
legitimate model/agent-name attributions untouched. Docs and comments
only, no behavior change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Delphi Coverage Report

File Stmts Miss Cover
init.py 2 0 100%
benchmarks/bench_pca.py 128 107 16%
benchmarks/bench_repness.py 81 65 20%
benchmarks/bench_update_votes.py 38 28 26%
benchmarks/benchmark_utils.py 34 24 29%
components/init.py 1 0 100%
components/config.py 165 70 58%
conversation/init.py 2 0 100%
conversation/conversation.py 1284 272 79%
conversation/manager.py 131 42 68%
database/init.py 1 0 100%
database/dynamodb.py 395 189 52%
database/postgres.py 322 109 66%
pca_kmeans_rep/init.py 5 0 100%
pca_kmeans_rep/clusters.py 257 38 85%
pca_kmeans_rep/corr.py 98 17 83%
pca_kmeans_rep/group_k_smoother.py 28 0 100%
pca_kmeans_rep/legacy_kmeans.py 176 6 97%
pca_kmeans_rep/pca.py 135 18 87%
pca_kmeans_rep/repness.py 226 5 98%
poller/init.py 4 0 100%
poller/math_writer.py 90 2 98%
poller/service.py 293 33 89%
poller/worker_pool.py 83 0 100%
queue/executor.py 223 111 50%
regression/init.py 4 0 100%
regression/clojure_comparer.py 188 20 89%
regression/comparer.py 887 645 27%
regression/datasets.py 135 27 80%
regression/recorder.py 36 27 25%
regression/utils.py 130 85 35%
replay/init.py 2 0 100%
replay/certify.py 890 44 95%
replay/crosslang.py 128 2 98%
replay/driver.py 55 1 98%
replay/equiv_query.py 10 0 100%
replay/fixture_bundle.py 697 53 92%
replay/fixture_config.py 204 11 95%
replay/fixture_extract.py 156 0 100%
replay/fixture_generate.py 103 1 99%
replay/fixture_survey.py 140 12 91%
replay/polarity.py 319 25 92%
replay/poller_equiv.py 777 99 87%
replay/prodclone.py 193 2 99%
replay/real_data.py 57 3 95%
replay/schedule.py 164 10 94%
replay/shard_bench.py 189 65 66%
replay/stagecompare.py 890 161 82%
replay/stages.py 256 40 84%
replay/stepcompare.py 77 1 99%
replay/store.py 120 11 91%
replay/types.py 68 6 91%
run_math_pipeline.py 262 114 56%
umap_narrative/500_generate_embedding_umap_cluster.py 210 109 48%
umap_narrative/501_calculate_comment_extremity.py 112 53 53%
umap_narrative/502_calculate_priorities.py 135 135 0%
umap_narrative/700_datamapplot_for_layer.py 502 502 0%
umap_narrative/701_static_datamapplot_for_layer.py 310 310 0%
umap_narrative/702_consensus_divisive_datamapplot.py 434 275 37%
umap_narrative/801_narrative_report_batch.py 790 726 8%
umap_narrative/802_process_batch_results.py 268 268 0%
umap_narrative/803_check_batch_status.py 185 185 0%
umap_narrative/llm_factory_constructor/init.py 2 0 100%
umap_narrative/llm_factory_constructor/model_provider.py 224 107 52%
umap_narrative/polismath_commentgraph/init.py 1 0 100%
umap_narrative/polismath_commentgraph/cli.py 270 270 0%
umap_narrative/polismath_commentgraph/core/init.py 3 3 0%
umap_narrative/polismath_commentgraph/core/clustering.py 108 108 0%
umap_narrative/polismath_commentgraph/core/embedding.py 104 104 0%
umap_narrative/polismath_commentgraph/lambda_handler.py 219 219 0%
umap_narrative/polismath_commentgraph/schemas/init.py 2 0 100%
umap_narrative/polismath_commentgraph/schemas/dynamo_models.py 160 9 94%
umap_narrative/polismath_commentgraph/tests/conftest.py 17 17 0%
umap_narrative/polismath_commentgraph/tests/test_clustering.py 74 74 0%
umap_narrative/polismath_commentgraph/tests/test_embedding.py 55 55 0%
umap_narrative/polismath_commentgraph/tests/test_storage.py 87 87 0%
umap_narrative/polismath_commentgraph/utils/init.py 3 0 100%
umap_narrative/polismath_commentgraph/utils/converter.py 283 237 16%
umap_narrative/polismath_commentgraph/utils/group_data.py 355 306 14%
umap_narrative/polismath_commentgraph/utils/storage.py 584 466 20%
umap_narrative/reset_conversation.py 159 50 69%
umap_narrative/run_pipeline.py 374 230 38%
umap_narrative/topic_naming.py 148 11 93%
utils/clj_hash.py 44 0 100%
utils/env_flags.py 13 0 100%
utils/general.py 63 39 38%
utils/output_profile.py 66 2 97%
utils/serialization.py 9 5 44%
utils/vote_convention.py 29 2 93%
Total 17741 7565 57%

@colinmegill
colinmegill merged commit 045a8bc into edge Sep 9, 2026
5 checks passed
@colinmegill
colinmegill deleted the chore/remove-internal-reviewer-labels branch September 9, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant