Repository navigation
chore: remove internal reviewer labels from comments, test names and docs - #2749
Merged
Merged
Conversation
…names Scrubs internal code-review labels from comments, docstrings, test/describe names, and one doc reference across delphi, server, cdk, ci, math, and the CI workflow. Neutral phrasing preserves the original meaning (e.g. "review round N", "the second reviewer's witness", "a headless worker"). A few test-local identifiers/constants that embedded the label were renamed and all references updated. Comments/docstrings/strings/test names/docs only — no behavior change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
Follow-up to the prior commit's review: replaces two manufactured, untracked filenames introduced by the earlier sweep with neutral descriptions of the review round instead (docs/engine-stage-oracles.md, delphi/tests/replay_harness/test_stages.py, and server/__tests__/unit/pcaMathTickZeroHttp.test.ts), and rewrites five pre-existing internal host-session identifiers in delphi/docs design and journal docs to neutral descriptions of the work session. Leaves legitimate model/agent-name attributions untouched. Docs and comments only, no behavior change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text-only cleanup, zero behaviour change: 39 files had internal reviewer/worker labels in comments, docstrings, test names, describe/test strings, and docs. They are replaced with neutral wording ("review round N", "the second reviewer", "a headless worker"). Identifier renames are confined to test-only symbols (four test functions and two constants in
test_certify_strict_gate.py; one local variable and one SQL literal inprojection_gate_test.py), with every reference updated.Not touched:
delphi/Dockerfileanddelphi/docs/QUICK_START.md(the unrelatedastral-shpackage maintainer), two lockfiles (the unrelatedastral-regexnpm package), and one notebook whose only match is a byte sequence inside a base64 image blob.Verification:
py_compileon every edited Python file;bash -non the two shell scripts; YAML parse of the workflow; the Clojure test file reads as well-formed forms;tsc --noEmitclean forserverandcdk;test_stages172 passed,test_polarity_property125 passed / 3 skipped,tests/projgate47 passed,test_certify_strict_gate143 passed, fence tests 23 passed / 8 skipped, four server unit files 95 passed,cdkalarms tests 49 passed. Integration suites that need the full Docker stack were not run here. Second review pending.🤖 Generated with Claude Code
https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s