DRYD-2042: Update AdvancedSearch Response for Materials and Herbarium#508
Merged
mikejritter merged 1 commit intocollectionspace:developfrom Mar 2, 2026
Conversation
spirosdi
approved these changes
Mar 2, 2026
Contributor
spirosdi
left a comment
There was a problem hiding this comment.
Looks good, changes tested and work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
materialto advanced search responsedeterminationTaxonto advanced search responseWhy are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2042
When testing the second release candidate we saw that the material field was not being populated in the materials profile. This was due to us not checking if profiles had added any additional fields to the response on
/collectionobjectbeing used to populate the old table.How should this be tested? Do these changes have associated tests?
materialsandherbariumprofilesDependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
The wiki for the advanced search response needs to be updated
Did someone actually run this code to verify it works?
@mikejritter tested locally