chore: add volunteer prakharrai1609#154
Open
prakharrai1609 wants to merge 1 commit intocodewithvoid:mainfrom
Open
chore: add volunteer prakharrai1609#154prakharrai1609 wants to merge 1 commit intocodewithvoid:mainfrom
prakharrai1609 wants to merge 1 commit intocodewithvoid:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codewithvoid
changed the title
codewithvoid
requested changes
Dec 26, 2022
| { | ||
| "name": "Prakhar Rai", | ||
| "bio": "SWE", | ||
| "image": "https://media.licdn.com/dms/image/D4D03AQH3nHT025rtWg/profile-displayphoto-shrink_400_400/0/1671091779353?e=1676505600&v=beta&t=iYhs7ybjojQC54tzE_bViSs1n6pVc45KTmVQzWBC18Y", |
Owner
There was a problem hiding this comment.
Can you use your github image url https://avatars.githubusercontent.com/u/58136319?v=4.
We have faced loading issue previously with linkedin cdn
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "name": "Prakhar Rai", | |||
| "bio": "SWE", | |||
Owner
There was a problem hiding this comment.
nit: Software Engineer
to make it more clear
| "image": "https://media.licdn.com/dms/image/D4D03AQH3nHT025rtWg/profile-displayphoto-shrink_400_400/0/1671091779353?e=1676505600&v=beta&t=iYhs7ybjojQC54tzE_bViSs1n6pVc45KTmVQzWBC18Y", | ||
| "categories": [ | ||
| { | ||
| "slug": "Problem solving", |
Owner
There was a problem hiding this comment.
slugs are pre-defined here
Add programming languages and DSA in programming category. Keep it max 2-3.
{
"slug": "programming",
"topics": ["C++", "Python", "DSA"]
}| "topics": ["C++", "Data structures", "Algorithms"] | ||
| }, | ||
| { | ||
| "slug": "Development", |
Owner
There was a problem hiding this comment.
Use web-development category slug here for web frameworks and technologies
{
"slug": "web-development",
"topics": [ "NodeJS", "ExpressJS", "Django"]
}
Owner
|
Thanks for volunteering @prakharrai1609. Added some comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.