fix: stop forwarding empty response when no response was received#134
Merged
fix: stop forwarding empty response when no response was received#134
Conversation
Collaborator
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
Can you please add a test for this scenario?
pawbana
force-pushed
the
pb/responses-write-header-fix
branch
from
57ddf2f to
7e9d0e7
Compare
dannykopping
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes edge case in responses blocking interceptor.
When no response was received from upstream, first custom error was sent then empty / not initialized copy of the response was forwarded.
Fix is to not sent empty copies of responses.