Skip to content

added new tests for temperature conversion and also fixed the convert… #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codepiyusss merged 1 commit into from
Oct 10, 2026
Merged

added new tests for temperature conversion and also fixed the convert… #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fixit/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ def km_to_miles(km: float) -> float:


def miles_to_km(miles: float) -> float:
return miles / KM_PER_MILE
return miles * KM_PER_MILE
14 changes: 13 additions & 1 deletion tests/test_convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@ def test_km_to_miles():
assert km_to_miles(10) == pytest.approx(6.21371, rel=1e-4)


@pytest.mark.xfail(reason="Known bug: miles_to_km divides instead of multiplies")
def test_miles_to_km():
assert miles_to_km(1) == pytest.approx(1.609344)


def test_negative_celsius():
assert celsius_to_fahrenheit(-20)==-4

def test_zero_celsius():
assert celsius_to_fahrenheit(0) == 32

def test_absolute_zero():
assert celsius_to_fahrenheit(-273.15) == pytest.approx(-459.67)

def test_float_km_to_miles():
assert km_to_miles(1.5) == pytest.approx(0.932056788)