Skip to content

Patch 1 - #44

Closed
Giorgx12 wants to merge 3 commits into
codepiyusss:mainfrom
Giorgx12:patch-1
Closed

Giorgx12 wants to merge 3 commits into
codepiyusss:mainfrom
Giorgx12:patch-1

Conversation

@Giorgx12

@Giorgx12 Giorgx12 commented Oct 8, 2026 •

Copy link
Copy Markdown

What does this PR do?

Related issue

Closes #31

Checklist

  • I commented on the issue first and was assigned
  • I removed the xfail marker (if fixing a bug)
  • I added or updated tests
  • pytest passes locally
  • This PR only addresses one issue

@Giorgx12

Giorgx12 commented Oct 8, 2026

Copy link
Copy Markdown
Author

Done! Let me know, goodbyee!

@Giorgx12

Giorgx12 commented Oct 8, 2026

Copy link
Copy Markdown
Author

Retried, i made an error

@codepiyusss

Copy link
Copy Markdown
Owner

Thanks for the PR, the tests are the right idea and 200 chars keeps them stable! One thing to fix before I can merge: both tests use string.punctuation, but the file never imports string, so they fail with a NameError. Please add import string at the top of tests/test_password.py, run pytest locally to confirm everything passes, and push the update. Also, could you add a one-line description under “What does this PR do?”.
Thanks!

@codepiyusss codepiyusss closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: test the password symbols option

2 participants