refactor: migrate config:check as a modern command#10355
Open
paulbalandan wants to merge 1 commit into
Open
Conversation
michalsn
approved these changes
Jun 30, 2026
datamweb
approved these changes
Jun 30, 2026
paulbalandan
force-pushed
the
config-check-modern
branch
from
26beec9 to
f34cb7a
Compare
Member
Author
|
I have revised the refactor to preserve the original behavior, i.e. it errors when the required argument is not provided. Previously, I added interactive prompting. Only difference now with develop is this is now depending on AbstractCommand's validation of missing required args instead of hand-rolling our own. |
michalsn
approved these changes
Jun 30, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Looks good.
Question. Should the user guide explicitly mention that command() does not catch exceptions, including validation exceptions from modern commands, and that callers should be prepared for it?
datamweb
approved these changes
Jun 30, 2026
datamweb
left a comment
datamweb
left a comment
Contributor
There was a problem hiding this comment.
Sounds good to me. I agree that documenting this behavior in the user guide would help set expectations.
5 tasks
Member
Author
|
Thanks all! Added note in #10360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #10120
This PR also renames some of the error messages to be more descriptive and natural.
Checklist: