Also expand non-declared template parameters #92
Open
dblock wants to merge 1 commit intocodegram:masterfrom
Open
Also expand non-declared template parameters #92dblock wants to merge 1 commit intocodegram:masterfrom
dblock wants to merge 1 commit intocodegram:masterfrom
Conversation
dblock
force-pushed
the
template-parameters
branch
from
5fc0318 to
a016242
Compare
dblock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a behavior change around #84.
I wonder whether we want this behavior by default? Missing variables just don't get expanded and additional ones now do. If we want this behavior by default we need a way to disable it. Otherwise we need a way to enable it.
We probably also want to kill the whole
templatedidea. If we're going to add any parameter to the request we might as well treat all links as templated.