Skip to content

⚡️ Speed up function areIntersecting by 51% #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: release
Choose a base branch
from
Open

⚡️ Speed up function areIntersecting by 51% #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions app/client/src/utils/boxHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,21 @@ export interface Rect {
}

export const areIntersecting = (r1: Rect, r2: Rect) => {
return !(
r2.left >= r1.right ||
r2.right <= r1.left ||
r2.top >= r1.bottom ||
r2.bottom <= r1.top
);
// Check left/right overlap first, with short-circuits to avoid unnecessary property reads.
const l2 = r2.left;
const r1r = r1.right;
if (!(l2 < r1r)) return false;

const r2r = r2.right;
const l1 = r1.left;
if (!(r2r > l1)) return false;

// Check top/bottom overlap next.
const t2 = r2.top;
const b1 = r1.bottom;
if (!(t2 < b1)) return false;

const b2 = r2.bottom;
const t1 = r1.top;
return b2 > t1;
};