Skip to content

⚡️ Speed up method LuaList.merge by 7% #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: fix/add-mockito-test-dependency
Choose a base branch
from
Open

⚡️ Speed up method LuaList.merge by 7% #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions client/src/com/aerospike/client/lua/LuaList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,16 @@ public void concat(LuaList list2) {
}

public LuaList merge(LuaList list2) {
List<LuaValue> target = new ArrayList<LuaValue>(this.list);
target.addAll(list2.list);
// Pre-size to combined capacity to avoid reallocation when adding
int size1 = this.list.size();
int size2 = list2.list.size();
List<LuaValue> target = new ArrayList<LuaValue>(size1 + size2);
if (size1 > 0) {
target.addAll(this.list);
}
if (size2 > 0) {
target.addAll(list2.list);
}
return new LuaList(instance, target);
}

Expand Down