Skip to content

⚡️ Speed up method Info.parseMultiResponse by 28% #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: fix/add-mockito-test-dependency
Choose a base branch
from
Open

⚡️ Speed up method Info.parseMultiResponse by 28% #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions client/src/com/aerospike/client/Info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,29 +565,31 @@ private String parseSingleResponse(String name) {
}

public HashMap<String,String> parseMultiResponse() throws AerospikeException {
HashMap<String, String> responses = new HashMap<String,String>();
// Use local references to minimize repeated field access in the hot loop.
final byte[] buf = this.buffer;
final int len = this.length;

// Reasonable default size to reduce rehashing for small responses.
HashMap<String,String> responses = new HashMap<String,String>(8);
int offset = 0;
int begin = 0;

while (offset < length) {
byte b = buffer[offset];
while (offset < len) {
byte b = buf[offset];

if (b == '\t') {
String name = Buffer.utf8ToString(buffer, begin, offset - begin);
String name = Buffer.utf8ToString(buf, begin, offset - begin);
offset++;
checkError();
begin = offset;

// Parse field value.
while (offset < length) {
if (buffer[offset] == '\n') {
break;
}
while (offset < len && buf[offset] != '\n') {
offset++;
}

if (offset > begin) {
String value = Buffer.utf8ToString(buffer, begin, offset - begin);
String value = Buffer.utf8ToString(buf, begin, offset - begin);
responses.put(name, value);
}
else {
Expand All @@ -597,7 +599,7 @@ public HashMap<String,String> parseMultiResponse() throws AerospikeException {
}
else if (b == '\n') {
if (offset > begin) {
String name = Buffer.utf8ToString(buffer, begin, offset - begin);
String name = Buffer.utf8ToString(buf, begin, offset - begin);
responses.put(name, null);
}
begin = ++offset;
Expand All @@ -608,7 +610,7 @@ else if (b == '\n') {
}

if (offset > begin) {
String name = Buffer.utf8ToString(buffer, begin, offset - begin);
String name = Buffer.utf8ToString(buf, begin, offset - begin);
responses.put(name, null);
}
return responses;
Expand Down