Skip to content

⚡️ Speed up method LuaUnpacker.getString by 5% #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: fix/add-mockito-test-dependency
Choose a base branch
from
Open

⚡️ Speed up method LuaUnpacker.getString by 5% #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion client/src/com/aerospike/client/lua/LuaUnpacker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@

public class LuaUnpacker extends Unpacker<LuaValue> {
private LuaInstance instance;
private static final int STRING_CACHE_SIZE = 256;
private static final int STRING_CACHE_MASK = STRING_CACHE_SIZE - 1;
private final String[] stringCacheKeys = new String[STRING_CACHE_SIZE];
private final LuaString[] stringCacheValues = new LuaString[STRING_CACHE_SIZE];

public LuaUnpacker(LuaInstance instance, byte[] buffer, int offset, int length) {
super(buffer, offset, length);
Expand All @@ -53,7 +57,26 @@ protected LuaBytes getBlob(byte[] value) {

@Override
protected LuaString getString(String value) {
return LuaString.valueOf(value);
// Preserve original behavior for null values (delegate directly),
// so any exceptions or handling that LuaString.valueOf does remain unchanged.
if (value == null) {
return LuaString.valueOf(value);
}

int h = value.hashCode();
int idx = (h ^ (h >>> 16)) & STRING_CACHE_MASK;
String key = stringCacheKeys[idx];

// Fast positive-hit path: return cached LuaString when key matches.
if (key != null && key.equals(value)) {
return stringCacheValues[idx];
}

// Miss: create LuaString and populate the cache slot.
LuaString ls = LuaString.valueOf(value);
stringCacheKeys[idx] = value;
stringCacheValues[idx] = ls;
return ls;
}

@Override
Expand Down