Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the REST adapter to stop assuming request bodies are protobuf-encoded Values and instead parse/encode bodies based on Content-Type, while also improving handling of non-HTTP “RuntimeError” results coming back from Taurus.
Changes:
- Parse incoming request bodies as JSON or text based on
Content-Type(with a fallback path for missingContent-Type). - Build a structured flow input containing request headers and optional payload, and detect/translate Taurus RuntimeError results to HTTP errors.
- Add helpers for mapping
tucana::shared::Valueresults intohyper::Responses, including response-body encoding byContent-Type.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
crates/base/src/store.rs |
Clones and debug-logs flow input around execution requests. |
adapter/rest/src/main.rs |
Switches request-body handling to Content-Type parsing; wraps request headers/payload into input Value; adds RuntimeError detection; uses new response helpers. |
adapter/rest/src/content_type.rs |
New module to parse/encode bodies by Content-Type with unit tests. |
adapter/rest/src/response.rs |
New module to convert flow result Value into an HTTP response (status/headers/body). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #196 & #197