Skip to content

Resource routes should open in a new window #33

Closed

Description

@houmark

On the routes tab, if you have a resource route and click the button to open the route, it will open in the same window, but data from the resource route is not shown as it requires a full browser reload to work.

P.S. Thanks for this, it's pretty cool :)

Activity

  1. AlemTuzlak commented on Jul 30, 2023

    @AlemTuzlak
    Contributor

    I'll see if theres a way to know if the route is a resource or not, will look into this further!

  2. houmark commented on Jul 31, 2023

    @houmark
    Author

    Not sure how you are parsing for information, and you are probably well aware of this, but in case you're not, the basic definition of a resource route is one that does not export a default component, so it should be somewhat simple to detect I think.

  3. AlemTuzlak commented on Aug 1, 2023

    @AlemTuzlak
    Contributor

    @houmark I'm fully aware, the issue is that the remix context doesn't expose this information until the route itself is mounted (which it's not on the routes page) so I would probably have to include remix forge into this to check beforehand or do some hacking so it's not really as simple and naive as it looks. But I have this in mind and will try to find a way to do it

  4. locked and limited conversation to collaborators on Sep 10, 2023
  5. converted this issue into a discussion #50 on Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions