ccl: move pkg/ccl/cloudccl to pkg/cloud#164591
ccl: move pkg/ccl/cloudccl to pkg/cloud#164591trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
stevendanna
requested review from
andrew-r-thomas
and removed request for
a team
|
😎 Merged successfully - details. |
|
This change is |
|
Do not merge until the Cloud Test pipeline in teamcity has passed against this branch and we've verified the same number of test executed. |
stevendanna
force-pushed
the
ssd/cloudccl-cya
branch
5 times, most recently
from
d6f9688 to
ca172b6
Compare
|
The cloud pipeline is busted at the moment. But this branch is at least failing in the same way as master is failing at the moment. I will look into this unit test shortly. |
|
Moving back to draft until these Unit test failures are sorted out. |
stevendanna
force-pushed
the
ssd/cloudccl-cya
branch
2 times, most recently
from
34aa33f to
9a2e56f
Compare
cockroach-teamcity
added
the
X-perf-gain
|
Test failure is unrelated. |
msbutler
left a comment
msbutler
left a comment
There was a problem hiding this comment.
Thank you for doing this!! have you already run a cloud unit test nightly smoke test?
Move cloud-related CCL test packages out of pkg/ccl/cloudccl and into pkg/cloud alongside the code they test. The tests in cloudccl were only separated because of historical CCL/OSS licensing distinctions which no longer apply. Packages moved: - pkg/ccl/cloudccl/amazon → pkg/cloud/amazon - pkg/ccl/cloudccl/azure → pkg/cloud/azure - pkg/ccl/cloudccl/gcp → pkg/cloud/gcp - pkg/ccl/cloudccl/externalconn → pkg/cloud/externalconn - pkg/ccl/cloudccl/cloudprivilege → pkg/cloud/cloudprivilege Along the way, fix the externalconn test Handle to propagate testing knobs to secondary tenants started via InitializeTenant, so the SkipCheckingExternalStorageConnection knob takes effect on all tenants. Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
stevendanna
force-pushed
the
ssd/cloudccl-cya
branch
from
9a2e56f to
34541ef
Compare
|
Unfortunately the nightlies are broken on master. So the best I can tell you is that this branch is equally broken: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_CloudUnitTests/21205849?expandBuildDeploymentsSection=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&hideTestsFromDependencies=false&expandBuildTestsSection=true |
|
/trunk merge. TFTR! I've gone ahead and merged this. I'll keep an eye on things but if you see any fallout I miss, just holler. |
|
Unknown command: |
|
/trunk merge |
celeste-cockroachdb
bot
added
v26.2.0-prerelease
and removed
target-release-26.2.0
labels
3 participants
Informs #164337
Release note: None