fix(toolbar): add back disabled support to toolbar buttons

[nandanmen]

Fixes a bug in Toolbar.Button where toolbar buttons cannot be disabled. This was causing a failing test in the main dashboard.

---

• Reviews
  • bonk has reviewed the change
  • automated review not possible because:
• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:

[pkg-pr-new]

npm i https://pkg.pr.new/@cloudflare/kumo@740

commit: d86676c

[github-actions]

Docs Preview

View docs preview

Commit: d86676c

[github-actions]

Visual Regression Report — 4 changed, 4 unchanged

4 screenshot(s) with visual changes:

Toolbar / Toolbar Select

1,077 px (1.22%) changed

Before	After	Diff

Toolbar / Toolbar Sizes

4,641 px (3.02%) changed

Before	After	Diff

Toolbar / Toolbar Actions

1,208 px (1.36%) changed

Before	After	Diff

Toolbar / Toolbar Labels

1,682 px (1.9%) changed

Before	After	Diff

4 screenshot(s) unchanged

• Toolbar / Toolbar
• Toolbar / Toolbar Combobox
• Toolbar / Toolbar Mixed Controls
• Toolbar / Toolbar Input Group

---

Generated by Kumo Visual Regression

[mattrothenberg]

/bonk review and approve

[ask-bonk]

Clean, focused fix. The single-line change correctly pipes disabled (and loading) to ToolbarBase.Button so Base UI can manage aria-disabled and roving focus semantics.

The three new browser tests cover the right surface area:

• Disabled state exposure and interaction blocking
• Loading state causing disablement
• focusableWhenDisabled roving focus behavior

Changeset is properly scoped as a patch. LGTM.

[ask-bonk]

Approved PR #740 (fix(toolbar): add back disabled support to toolbar buttons).

Review summary:

• Fix: One-line change adding disabled={loading || disabled} to ToolbarBase.Button so Base UI correctly manages aria-disabled and roving focus semantics.
• Tests: Three new browser tests covering disabled state exposure, loading-state disablement, and focusableWhenDisabled roving focus behavior — all pass and cover the bug surface well.
• Changeset: Properly scoped as a patch.

No issues found. The fix is minimal, correct, and well-tested.

github run