Skip to content

Add Text heading variant - #739

Merged
mattrothenberg merged 1 commit into
cloudflare:mainfrom
nandanmen:nanda/update-text-size
Aug 20, 2026
Merged

Add Text heading variant#739
mattrothenberg merged 1 commit into
cloudflare:mainfrom
nandanmen:nanda/update-text-size

Conversation

@nandanmen

@nandanmen nandanmen commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a new heading variant to text with base and lg sizes:

<Text variant="heading">Heading base</Text>
<Text variant="heading" size="lg">Heading large</Text>
CleanShot 2026-08-19 at 11 28 22@2x

Deprecates the current heading1, heading2, and heading3 variants.

Testing

  • pnpm --filter @cloudflare/kumo test

  • pnpm --filter @cloudflare/kumo typecheck

  • pnpm --filter @cloudflare/kumo lint

  • pnpm --filter @cloudflare/kumo-figma exec vp test run src/generators/text.test.ts

  • pnpm --filter @cloudflare/kumo-figma exec tsc --noEmit

  • pnpm --filter @cloudflare/kumo-docs-astro typecheck

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: an automated reviewer was not available in this environment

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows:

  • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@739

commit: e8fcbe1

@github-actions

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: e8fcbe1

@github-actions

Copy link
Copy Markdown
Contributor
Visual Regression Report — 25 changed, 18 unchanged

25 screenshot(s) with visual changes:

Button / With Icon

797 px (0.9%) changed

Before After Diff
Before After Diff

Button / Loading State

855 px (0.97%) changed

Before After Diff
Before After Diff

Button / Disabled State

0 px (0%) changed

Before After Diff
Before After Diff

Button / Link as Button

820 px (0.93%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

298 px (0.34%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

316 px (0.36%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,321 px (1.49%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

1,735 px (1.96%) changed

Before After Diff
Before After Diff

Dialog / Custom Max Width

303 px (0.34%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

130 px (0.15%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

383 px (0.43%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

480 px (0.54%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Basic

859 px (0.97%) changed

Before After Diff
Before After Diff

Select / Select Sizes

3,182 px (1.96%) changed

Before After Diff
Before After Diff

Select / Select With Description

1,688 px (1.62%) changed

Before After Diff
Before After Diff

Select / Select With Error

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

1,279 px (1.44%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

982 px (1.11%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

1,076 px (1.21%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,125 px (1.2%) changed

Before After Diff
Before After Diff

Select / Select Complex

1,655 px (1.59%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

814 px (0.92%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

999 px (1.13%) changed

Before After Diff
Before After Diff

Select (Open)

2,237 px (0.01%) changed

Before After Diff
Before After Diff
18 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / Icon Only
  • Button / Title
  • Button / Link with Tooltip
  • Button / Disabled Link
  • Dialog / Dialog Sizes
  • Select / Select Without Label
  • Select / Select Multiple
  • Select / Select Disabled Options
  • Select / Select Grouped
  • Select / Select Long List

Generated by Kumo Visual Regression

@mattrothenberg
mattrothenberg merged commit 716e5b8 into cloudflare:main Aug 20, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants