Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-links-select.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/kumo": patch
---

Allow users to select and copy LinkButton text while preserving Button text selection behavior.
25 changes: 25 additions & 0 deletions packages/kumo/src/components/button/button.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ describe("Button", () => {
expect(button.hasAttribute("disabled")).toBe(true);
});

it("prevents text selection", () => {
render(<Button>Save</Button>);
const button = screen.getByRole("button");
expect(button.classList.contains("select-none")).toBe(true);
expect(button.classList.contains("select-text")).toBe(false);
});

it("forwards ref to the <button> DOM node", () => {
const ref = React.createRef<HTMLButtonElement>();
render(<Button ref={ref}>Click</Button>);
Expand Down Expand Up @@ -207,6 +214,13 @@ describe("LinkButton", () => {
expect(link.getAttribute("href")).toBe("/home");
});

it("allows text selection", () => {
render(<LinkButton href="/home">Home</LinkButton>);
const link = screen.getByRole("link");
expect(link.classList.contains("select-text")).toBe(true);
expect(link.classList.contains("select-none")).toBe(false);
});

it("external sets target='_blank' and rel='noopener noreferrer'", () => {
render(
<LinkButton href="https://example.com" external>
Expand Down Expand Up @@ -283,6 +297,17 @@ describe("LinkButton", () => {
expect(button.getAttribute("data-kumo-component")).toBe("LinkButton");
});

it("allows text selection", () => {
render(
<LinkButton href="/home" disabled>
Home
</LinkButton>,
);
const button = screen.getByRole("button", { name: "Home" });
expect(button.classList.contains("select-text")).toBe(true);
expect(button.classList.contains("select-none")).toBe(false);
});

it("wraps a title in an enabled tooltip trigger around the disabled button", () => {
render(
<LinkButton href="/home" disabled title="You need edit access">
Expand Down
4 changes: 2 additions & 2 deletions packages/kumo/src/components/button/button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ export const LinkButton = React.forwardRef<HTMLAnchorElement, LinkButtonProps>(
return (
<Button
{...toDisabledButtonProps(props)}
className={className}
className={cn("select-text", className)}
data-kumo-component="LinkButton"
disabled
icon={IconComponent}
Expand All @@ -501,7 +501,7 @@ export const LinkButton = React.forwardRef<HTMLAnchorElement, LinkButtonProps>(
data-kumo-component="LinkButton"
className={cn(
buttonVariants({ variant, size, shape }),
"flex items-center no-underline!",
"flex items-center no-underline! select-text",
className,
)}
href={href}
Expand Down
Loading