Skip to content

fix: removed field auto_added#258

Open
r-birkner wants to merge 1 commit intocloudflare:masterfrom
dfinity:rjb/fix-added-account
Open

fix: removed field auto_added#258
r-birkner wants to merge 1 commit intocloudflare:masterfrom
dfinity:rjb/fix-added-account

Conversation

@r-birkner
Copy link
Copy Markdown

No description provided.

@kennetheversole
Copy link
Copy Markdown
Contributor

Can you please provide more context on the issue this was causing?

@r-birkner
Copy link
Copy Markdown
Author

We use this crate to create DNS records for the ACME-challenge. With this field, there would be a panic because the crate failed to deserialize the response as the field was missing (it has been deprecated, see here).

I have noticed that you have overhauled the codebase quite a bit. We are running off of a fork with the applied fixes. I can try switching back to the upstream and see whether it works now.

@Riceman2000
Copy link
Copy Markdown
Contributor

@kennetheversole
Here is the error message produced when DNS records are listed with version 0.13.0:

API request to list existing records failed with: Invalid(reqwest::Error { kind: Decode, source: Error("missing field `auto_added`", line: 1, column: 181) })

Thanks @r-birkner for putting this fix together.

@GoncaloGarcia
Copy link
Copy Markdown
Contributor

@r-birkner Could you rebase this please?

@ErcinDedeoglu
Copy link
Copy Markdown

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants