Open
Conversation
Contributor
|
Can you please provide more context on the issue this was causing? |
Author
|
We use this crate to create DNS records for the ACME-challenge. With this field, there would be a panic because the crate failed to deserialize the response as the field was missing (it has been deprecated, see here). I have noticed that you have overhauled the codebase quite a bit. We are running off of a fork with the applied fixes. I can try switching back to the upstream and see whether it works now. |
Contributor
|
@kennetheversole Thanks @r-birkner for putting this fix together. |
Contributor
|
@r-birkner Could you rebase this please? |
|
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.