Convert remaining .mjs scripts to TypeScript - #549
Merged
Merged
Conversation
#233 moved `scripts/` to type-stripped TypeScript but left four `.mjs` files behind: the two gatekeeper `build-app` scripts, workshop-backend's browser-runtime builder, and the oxlint plugin. They now run as `.ts` and are type-checked by `pnpm types:scripts`. - `build-browser-runtime` moves into `workshop-backend/scripts/`, beside the other Node-only tool that `scripts/tsconfig.json` already covers. - The oxlint plugin is typed against `@oxlint/plugins`, added as a type-only dev dependency pinned to the version Vite+ pins; its test fails if the two drift. oxlint loads a `.ts` plugin as-is. - Stale references to already-converted `.mjs` files are corrected. Co-Authored-By: Claude Code <noreply@anthropic.com>
github-actions
Bot
added
kernel
Preview:
|
|
LGTM! |
Maximo-Guk
marked this pull request as ready for review
September 22, 2026 15:19
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
AshishKumar4
approved these changes
Sep 22, 2026
tosaka07
added a commit
to tosaka07/cloudflare-os
that referenced
this pull request
Sep 25, 2026
* origin/main: Fix getting stuck on a failed MCP approval (cloudflare#566) Structured action fields (cloudflare#565) Fix getting stuck verifying access to a shared workspace (cloudflare#559) Upgrade pi to 0.87.1 for Claude 5.5 and GPT-6 (cloudflare#556) Assert XLSX batching by compressor writes, not wall-clock time (cloudflare#562) Complete action descriptions for public gatekeepers (cloudflare#541) Cap tool results at 32K; add grep and line ranges to readFile (cloudflare#494) Fix revert elision for a readFile in the same step as the reverted edit (cloudflare#522) feat(gatekeeper-kit): oauth 2.0 token client (cloudflare#555) Review with GPT-6 Sol and opencode 1.18.32 in Bonk (cloudflare#550) Add a unified Google Drive Folder resource (cloudflare#440) Convert the remaining .mjs build scripts to TypeScript (cloudflare#549) Reconnect the agent session; run trials concurrently; render trajectories (cloudflare#512) Add shared UI package and hierarchical list (cloudflare#484) Owner-invites-only latch for workspaces that observed opted-in sensitive data (cloudflare#523) Frontend: Invite several people at once from the share modal (cloudflare#526) Extend code editor UI to cover worktrees (cloudflare#513) Document and test staged gatekeeper reconnects (cloudflare#520) Fix bundled blueprint test PID assumption (cloudflare#524) Default evals to GPT 5.6 Luna with ten trials per task (cloudflare#521)
bashandbone
added a commit
to knitli/knitli-os
that referenced
this pull request
Sep 25, 2026
Merge of foundation/main tip `a43210a7` into the fork. Upstream range: structured action fields (cloudflare#565, cloudflare#541), pi 0.87.1 (cloudflare#556), grep tool + 32K caps + readFile windows (cloudflare#494), revert elision (cloudflare#522), failed-approval discard (cloudflare#566), OAuth token client (cloudflare#555), Drive folder resource (cloudflare#440), .mjs-to-.ts (cloudflare#549), shared-workspace verify fix (cloudflare#559), XLSX test (cloudflare#562), Bonk review config (cloudflare#550). Hand resolutions (Tier 2, upstream-first) and custom-code reductions (maxArguments retired, GLM override removed, blindfold consolidated into scanWorkpieceForGrep) are detailed in the merge commit message. Fork gates pass: fork-boundary, sync-upstream, upstream-merge-audit (82/82). Reviewed by two independent agents; fix pass clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the four
.mjsfiles #233 left behind (two gatekeeperbuild-appscripts, workshop-backend's browser-runtime builder, the oxlint plugin) to type-checked TypeScript.The plugin is typed via a type-only
@oxlint/pluginsdev dependency pinned to Vite+'s version, with a test guarding the pin.