Skip to content

keynote-2: alpha -> 1.5, withConfirmedReads(true), remove warmup#4492

Merged
clockwork-labs-bot merged 1 commit intomasterfrom
centril/bench-tweaks
Feb 28, 2026
Merged

keynote-2: alpha -> 1.5, withConfirmedReads(true), remove warmup#4492
clockwork-labs-bot merged 1 commit intomasterfrom
centril/bench-tweaks

Conversation

@Centril
Copy link
Contributor

@Centril Centril commented Feb 27, 2026

Description of Changes

This does 3 things to the keynote-2 benchmark:

  • it changes the default alpha to 1.5, which we actually tested the other services with
  • it turns on confirmed reads (not the default for < 2.0)
  • it removes warmup

This was tested on #4404 to have no impact on the TPS throughput of spacetimedb.
This PR shouldn't be merged before #4404 has.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

This tweaks a bench test.

@Centril Centril requested a review from kim February 27, 2026 20:44
@clockwork-labs-bot clockwork-labs-bot added this pull request to the merge queue Feb 27, 2026
@Centril Centril removed this pull request from the merge queue due to a manual request Feb 27, 2026
@clockwork-labs-bot clockwork-labs-bot added this pull request to the merge queue Feb 28, 2026
Merged via the queue into master with commit abbcec4 Feb 28, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants