[C#] Add support for IEnumerable<T> for Views' return types#4486
Open
[C#] Add support for IEnumerable<T> for Views' return types#4486
Conversation
Signed-off-by: Ryan <r.ekhoff@clockworklabs.io>
Comment on lines
1236
to
1237
| && !ReturnType.BSATNName.Contains("SpacetimeDB.BSATN.RefOption") | ||
| && !ReturnType.BSATNName.Contains("SpacetimeDB.BSATN.List") |
Collaborator
There was a problem hiding this comment.
Do both of these options implement IEnumerable? If so, we could just assert IEnumerable or IQuery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation to resolve #4424
Description of Changes
IEnumerable<T>as a valid C# View return type in codegen, so view implementations can return query results without forcingToList(). The generator now detectsIEnumerable<T>, serializes it via the list serializer.IEnumerable<T>rather than checking it is unsupported (which we had added when removing support during the transition away fromQuery<T>usage.API and ABI breaking changes
No breaking changes. This is additive support for an existing .NET interface.
Expected complexity level and risk
2 - Low
Testing
dotnet testsin C# module bindings.