[TS] Fix returning a query from a view that returns an option#4408
Open
coolreader18 wants to merge 1 commit intomasterfrom
Open
[TS] Fix returning a query from a view that returns an option#4408coolreader18 wants to merge 1 commit intomasterfrom
coolreader18 wants to merge 1 commit intomasterfrom
Conversation
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
Note, the type signature becomes a little misleading in this case because currently we don't have a way of determining statically whether a query builder view returns at most 1 row.
So I would say we don't want this change but rather would like to restrict the return type to array for query builder returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This was an issue in 1.x as well, so it's not theoretically blocking 2.0.
Expected complexity level and risk
1
Testing
PersonAtLevel2view works correctly now.