Repository navigation
feat(jumpover): add jumpPriority option - #3592
Closed
kumilingus wants to merge 5 commits into
Closed
kumilingus wants to merge 5 commits into
kumilingus wants to merge 5 commits into
Conversation
…ion, skip links that cannot cross
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
jumpPriorityoption ofconnectors.jumpover. Where two jumpover links cross, it decides which of them draws the jump:'paint-order'(default) - the link painted on top, as before'vertical'- the more vertical link'horizontal'- the more horizontal linkEqually steep links fall back to the paint order, so every crossing still gets exactly one jump. When the two links have a different
jumpPriority, the one of the link painted on top applies. A link with another connector never draws jumps, so a jumpover link always jumps over it.With
'vertical', a link crossing a track of parallel horizontal links draws all the jumps itself, instead of some of them being on the track and some on the crossing link.This branch also contains the jumpover fixes of #3591 (one jump over a track of links, jump direction on nearly vertical lines, skipping links whose routes cannot cross), which are not on
devyet.Test plan
joint: 2262 passed. New tests:paint-order(default, explicit and invalid value),vertical,horizontaljumpPriorityon the two links, the one of the top link appliesjumpPriorityis ignored (3 failures) and when each link applies only its ownjumpPriority(1 failure).yarn test-server,yarn lint,yarn test-ts: pass.jumpPriority: 'vertical'and'horizontal'match the paths of an independent implementation of the same rule.Context
Refs #3510.