Simplify script by reducing validations and regex usage#17
Merged
Conversation
Simplify the code in `bin/dotload` by reducing validations and regex usage, and delegating validation to git. * Remove the `error_msg` function and the `check_repo_exists` function. * Simplify the branch validation logic. * Simplify the username and repository name extraction logic. * Remove the repository existence check. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/cli-stuff/dotload?shareId=XXXX-XXXX-XXXX-XXXX).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the code in
bin/dotloadby reducing validations and regex usage, and delegating validation to git.error_msgfunction and thecheck_repo_existsfunction.For more details, open the Copilot Workspace session.