Skip to content

chore(localizations): Add missing Romanian translations for sign-in and sign-up - #10195

Open
vicuts wants to merge 1 commit into
clerk:mainfrom
vicuts:chore/localizations-ro-ro-sign-in-up
Open

vicuts wants to merge 1 commit into
clerk:mainfrom
vicuts:chore/localizations-ro-ro-sign-in-up

Conversation

@vicuts

@vicuts vicuts commented Oct 10, 2026

Copy link
Copy Markdown

Description

Adds Romanian (ro-RO) translations for the sign-in and sign-up keys that were still undefined, so Romanian users no longer see English fallback text on these screens.

The wording follows the informal register ("tu") already used across the ro-RO sign-in and sign-up strings. Where the English source matches an existing string, the existing Romanian translation is reused (for example Nu ai primit un cod? Retrimite, Verifică-ți emailul and Parola este compromisă).

Key English (en-US) Romanian (ro-RO)
signIn.emailLink.verifiedTransferable.title Email verified Email verificat
signIn.emailLink.verifiedTransferable.subtitle Return to original tab to continue Revino în fila inițială pentru a continua
signIn.enterpriseSSO.formButtonPrimary Continue with SSO Continuă cu SSO
signIn.passwordCompromised.title Password compromised Parola este compromisă
signIn.passwordUntrusted.title Password untrusted Parola nu este de încredere
signIn.protectCheck.loading Loading… Se încarcă…
signIn.protectCheck.retryButton Try again Încearcă din nou
signIn.protectCheck.subtitle Please wait while we verify your request. Te rugăm să aștepți cât timp îți verificăm solicitarea.
signIn.protectCheck.title Verifying your request Se verifică solicitarea
signIn.ssoBypass.actionLink Can't use SSO? Nu poți folosi SSO?
signIn.ssoBypass.code.resendButton Didn't receive a code? Resend Nu ai primit un cod? Retrimite
signIn.ssoBypass.code.subtitle to continue to {{applicationName}} pentru a continua la {{applicationName}}
signIn.ssoBypass.code.title Check your email Verifică-ți emailul
signIn.ssoBypass.notice Your organization requires single sign-on. Continuing without it is recorded. Organizația ta impune autentificarea unică (SSO). Dacă continui fără ea, acest lucru va fi înregistrat.
signUp.protectCheck.loading Loading… Se încarcă…
signUp.protectCheck.retryButton Try again Încearcă din nou
signUp.protectCheck.subtitle Please wait while we verify your request. Te rugăm să aștepți cât timp îți verificăm solicitarea.
signUp.protectCheck.title Verifying your request Se verifică solicitarea

signIn.enterpriseConnections and signUp.enterpriseConnections are left as they are, since #9805 adds new keys to those objects and editing them here would conflict.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.

Both were run filtered to @clerk/localizations (pnpm build --filter=@clerk/localizations, pnpm test --filter=@clerk/localizations), together with the package's generate, format:check and lint scripts.

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Localization update (Romanian)

@changeset-bot

changeset-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09447dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/localizations Patch
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 10, 2026

Copy link
Copy Markdown

@vicuts is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c966b5c2-fd51-47cd-a9f4-5c0aaecf4fac

📥 Commits

Reviewing files that changed from the base of the PR and between 2466563 and 09447dc.


📒 Files selected for processing (2)
  • .changeset/calm-pens-translate.md
  • packages/localizations/src/ro-RO.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.



📝 Walkthrough

Walkthrough

Romanian localization entries now provide text for additional sign-in and sign-up verification and authentication states. A patch changeset records the update.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mauricioabreu


Merge Risk: ⚪ Minimal · up to 09447

The update fills missing Romanian authentication prompts without changing their intended meaning or the localization contract. No identified merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 09447

The change affects 1 system.

Changed systems: packages/localizations

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/localizations (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/localizations/src/ro-RO.ts: signIn.emailLink.verifiedTransferable now provides Romanian subtitle and title text instead of undefined.
  • observed — Modified behavior in packages/localizations/src/ro-RO.ts: signIn.enterpriseSSO.formButtonPrimary now displays Romanian text for continuing with SSO instead of undefined.
  • observed — Modified behavior in packages/localizations/src/ro-RO.ts: signIn.passwordCompromised.title and signIn.passwordUntrusted.title now have Romanian text instead of undefined; the intervening passwordPwned.title remains unchanged.
  • observed — Modified behavior in packages/localizations/src/ro-RO.ts: signIn.protectCheck now provides Romanian loading, retry, subtitle, and title text instead of undefined.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check Passed The description clearly explains the Romanian localization changes, affected keys, translation choices, and validation performed.
Title check Passed The title clearly and concisely identifies the addition of missing Romanian translations for sign-in and sign-up.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant