Skip to content

feat(mosaic): connect organization membership requests - #10165

Merged
austincalvelage merged 4 commits into
mainfrom
austin/requests-tab-wire-up
Oct 9, 2026
Merged

austincalvelage merged 4 commits into
mainfrom
austin/requests-tab-wire-up

Conversation

@austincalvelage

Copy link
Copy Markdown
Member

Description

Connects the Mosaic Requests tab to pending organization membership requests. The tab appears when organization domains are enabled and the user can manage memberships. Users can accept or decline requests, retry failed loads and actions, and page through the list.

Accepting a request refreshes the Members list. Completing the final requests on a later page returns to the previous page, including when row actions overlap. Existing row controls own pending and error states.

Stacked on #10164. This covers the requests table and its actions. Verified-domain management and sending invitations remain separate. All new logic stays inside Mosaic.

Checklist

  • pnpm test runs as expected for the targeted organization-profile suites.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 9, 2026 7:46pm UTC
swingset Ready Ready Preview Oct 9, 2026 7:46pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 493fa42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: f6c68279-835d-4178-8725-64c6a789e519

📥 Commits

Reviewing files that changed from the base of the PR and between 7b5f2c2 and 493fa42.


📒 Files selected for processing (15)
  • .changeset/quiet-requests-tab.md
  • packages/mosaic/src/__tests__/feature/fake-fapi.ts
  • packages/mosaic/src/__tests__/feature/fake-fapi/organization-members.ts
  • packages/mosaic/src/features/organization-profile/__tests__/organization-profile-requests.feature.test.tsx
  • packages/mosaic/src/features/organization-profile/__tests__/requests-table-tab.view.test.tsx
  • packages/mosaic/src/features/organization-profile/organization-profile-members-panel.model.ts
  • packages/mosaic/src/features/organization-profile/organization-profile-members-panel.tsx
  • packages/mosaic/src/features/organization-profile/requests-table-tab.controller.ts
  • packages/mosaic/src/features/organization-profile/requests-table-tab.messages.ts
  • packages/mosaic/src/features/organization-profile/requests-table-tab.model.ts
  • packages/mosaic/src/features/organization-profile/requests-table-tab.types.ts
  • packages/mosaic/src/features/organization-profile/requests-table-tab.view.tsx
  • packages/mosaic/src/localization/errors.messages.ts
  • packages/swingset/src/stories/fixtures/requests-table-tab.ts
  • packages/swingset/src/stories/organization-profile-members-panel.mdx

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:


Included review availability: This review used your included allowance. 5 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.



📝 Walkthrough

Walkthrough

The organization profile now displays a Requests tab when membership management is allowed and organization domains are enabled. The table loads pending requests in pages of 10 and supports accepting or rejecting requests. It includes loading, error, retry, and empty states. Search and sorting controls are removed. Feature tests cover permissions, decisions, paging, failures, and organization or session changes.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: alexcarpenter


Merge Risk: ⚪ Minimal · up to 493fa

The Requests tab is permission-gated and has loading, error, retry, and paging states, with feature tests covering the main flows. I found no merge-blocking risk in the supplied context.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 13 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: connecting organization membership requests to Mosaic.
Description check Passed The description directly explains the Requests tab integration, permissions, request actions, retries, and pagination covered by the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 13 files. (2 skipped: 2 unsupported.)



  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@austincalvelage
austincalvelage force-pushed the austin/invitations-tab-wire-up branch from f214991 to ede77f6 Compare October 9, 2026 18:39
Base automatically changed from austin/invitations-tab-wire-up to main October 9, 2026 18:53
…ns tables

Replace cached rows with the table error state when a refresh fails,
drop the search, sort and page-size controls the membership requests
API cannot serve, localize request_unavailable, and reject invalid
request statuses in the fake FAPI as clerk_go does.
@pkg-pr-new

pkg-pr-new Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10165

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10165

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10165

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10165

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10165

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10165

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10165

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10165

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10165

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10165

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10165

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10165

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10165

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10165

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10165

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10165

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10165

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10165

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10165

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10165

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10165

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10165

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10165

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10165

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10165

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10165

commit: 493fa42

@austincalvelage
austincalvelage marked this pull request as ready for review October 9, 2026 19:44
@austincalvelage
austincalvelage enabled auto-merge (squash) October 9, 2026 19:48
@austincalvelage
austincalvelage merged commit 785190c into main Oct 9, 2026
53 of 86 checks passed
@austincalvelage
austincalvelage deleted the austin/requests-tab-wire-up branch October 9, 2026 19:54

This branch was successfully deployed

2 active deployments
Preview – swingset — 493fa42c Deployed Oct 9, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 493fa42c Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants