fix: address CodeRabbit review feedback on PR #413#414
Closed
blacksmith-sh[bot] wants to merge 2 commits intomainfrom
Closed
fix: address CodeRabbit review feedback on PR #413#414blacksmith-sh[bot] wants to merge 2 commits intomainfrom
blacksmith-sh[bot] wants to merge 2 commits intomainfrom
Conversation
- performanceShim: add no-arg getEntries() so the 'as typeof performance' cast is accurate for callers (Bun, OTel, dev tooling). - scripts/dev: make production NODE_ENV opt-in via CLAUDE_CODE_FORCE_NODE_ENV so dev-only diagnostics (DevBar, doctorDiagnostic, AutoUpdater dev branches, etc.) keep working by default. - gemini/index: switch deep-relative Tools import to the src/* path alias. - screens/REPL: drop the unnecessary 'as any' on the getPipeIpc selector to match other call sites.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
- performanceShim: replace 'as any' on the onresourcetimingbufferfull getter/setter and the globalThis install guard with typed intersection casts, per the project's TS guideline. - fileHistory: clarify the MAX_SNAPSHOTS comment so it reflects that checkpointing is throttled (cap reduced from 100 to 20), not disabled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #413 was already merged before the CodeRabbit review feedback could be applied, so this PR follows up with the legitimate fixes.
How it works:
src/utils/performanceShim.ts: adds the no-argumentgetEntries()overload so the finalas typeof performancecast is accurate. Returns the union ofmarkandmeasureentries by reusinggetEntriesByType. Bun, OTel exporters, and various dev/observability tooling call this and would have thrownTypeError: performance.getEntries is not a functionafter the shim installed.scripts/dev.ts: makes the React production-mode optimization opt-in. The productionNODE_ENVwas disabling 15+ dev-only branches (DevBar, doctorDiagnostic, AutoUpdater dev paths, warningHandler, etc.). It now defaults todevelopmentand can be re-enabled withCLAUDE_CODE_FORCE_NODE_ENV=production bun run devfor sessions that need the memory optimization.src/services/api/gemini/index.ts: replaces the deep../../../Tool.jsrelative import with thesrc/Tool.jsalias per the project's import-path guideline.src/screens/REPL.tsx: drops the unnecessaryas anyon thegetPipeIpcselector so it matches the other call sites inuseMasterMonitoranduseSlaveNotifications.Verified locally with
bunx tsc --noEmit(zero errors). The remaining CodeRabbit suggestion to addmarkResourceTiming,eventCounts, and theEventTargetsurface to the shim was skipped since no consumer in the codebase calls them and stubbing the full surface goes beyond the minimal fix.Need help on this PR? Tag
@codesmithwith what you need.