Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d33d68b
Update main CI to PostgreSQL 17.12, 18.7 and 19rc2
ihalatci Nov 13, 2026
118de5b
Use dev test images with matched PostgreSQL libpq versions
ihalatci Nov 13, 2026
c6bf192
Preserve nulling metadata in catalog visibility predicates
ihalatci Nov 13, 2026
212d652
Avoid reintroducing eliminated outer-join relations
ihalatci Nov 13, 2026
bea0385
Use main's declared-pointer iteration helper
ihalatci Nov 13, 2026
223abee
Update regression and development Python dependencies
ihalatci Nov 13, 2026
19800f2
Preserve PG19 base-relation visibility filter semantics
ihalatci Nov 13, 2026
bb1bc58
Handle eliminated joined subtrees on nullable join sides
ihalatci Nov 13, 2026
a9f6156
Account for upstream row-type and schema-lock checks
ihalatci Nov 13, 2026
537ff58
Accept local-only plans after nullable join elimination
ihalatci Nov 13, 2026
dfbcc28
Apply pinned formatter to main planner changes
ihalatci Nov 13, 2026
99fab5d
Test with matched PostgreSQL and patched dependency images
ihalatci Nov 13, 2026
29adb0b
Require transformed relation evidence before outer join replacement
ihalatci Nov 13, 2026
9b24f89
Keep outer join fixture setup on the coordinator
ihalatci Nov 13, 2026
994fc5d
Make three tests minor-version independent and drop their alternative…
onurctirtir Nov 16, 2026
42b2389
Keep outer join rows whose only match is a hidden pg_class row
onurctirtir Nov 16, 2026
d1a2676
Drop the join removal test for hidden pg_class rows
onurctirtir Nov 16, 2026
898ee98
Merge branch 'main' into ihalatci-citus-main-pg-update
ihalatci Nov 18, 2026
48be61f
Fix normalization of eliminated outer joins
colm-mchugh Nov 18, 2026
36a1c1a
Test PostgreSQL 19.0 GA with paired development images
ihalatci Nov 19, 2026
7e202b1
Remap system and whole-row Vards of eliminated outer join relations.
colm-mchugh Nov 20, 2026
ecec459
Treat both sides of a FULL join as nullable when normalizing removed …
colm-mchugh Nov 20, 2026
23c7ed5
Consume merged mitmproxy fork with Tornado 6.6.1
ihalatci-msft Nov 21, 2026
05c3b54
Test merged fork dependencies with verified development images
ihalatci Nov 22, 2026
e98c4a2
Consume verified header-corrected dev test images
ihalatci-msft Nov 22, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .devcontainer/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
black==26.3.1
black==26.10.1
click==8.1.7
isort==5.12.0
mypy-extensions==1.0.0
packaging==23.2
pathspec==1.0.0
platformdirs==4.0.0
pytokens==0.4.1
tomli==2.0.1
typing_extensions==4.8.0
18 changes: 10 additions & 8 deletions .devcontainer/src/test/regress/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,37 @@ url = "https://pypi.python.org/simple"
verify_ssl = true

[packages]
pyasn1 = ">=0.6.4"
mitmproxy = {git = "https://github.com/citusdata/mitmproxy.git", ref = "a16444362cc0393ccf7329f50fc909b711729de7"}
pyasn1 = ">=0.6.5"
mitmproxy = {git = "https://github.com/citusdata/mitmproxy.git", ref = "5cd63296e7dab274e275553df76e9699ea220032"}
"aioquic" = ">=1.2.0,<1.3.0"
"mitmproxy-rs" = ">=0.12.6,<0.13.0"
argon2-cffi = ">=23.1.0"
bcrypt = ">=4.1.2"
brotli = "<=1.2.0"
brotli = "==1.2.1"
h11 = "==0.16.0"
h2 = "==4.4.1"
tornado = ">=6.5.8,<6.6.0"
msgpack = ">=1.2.1"
tornado = "==6.6.1"
msgpack = "==1.2.3"
urwid = "==4.0.7"
zstandard = ">=0.25.0"
construct = "*"
docopt = "==0.6.2"
cryptography = "==50.0.0"
pytest = "==9.0.3"
psycopg = "*"
filelock = "*"
filelock = "==4.2.1"
certifi = "==2026.10.19"
pytest-asyncio = "*"
pytest-timeout = "*"
pytest-xdist = "*"
pytest-repeat = "*"
pyyaml = "*"
werkzeug = "==3.1.6"
werkzeug = "==3.1.9"
"typing-extensions" = ">=4.13.2,<5"
pyperclip = "==1.9.0"

[dev-packages]
black = "==26.3.1"
black = "==26.10.1"
isort = "*"
flake8 = "*"
flake8-bugbear = "*"
Expand Down
556 changes: 330 additions & 226 deletions .devcontainer/src/test/regress/Pipfile.lock

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ jobs:
pgupgrade_image_name: "ghcr.io/citusdata/pgupgradetester"
style_checker_image_name: "ghcr.io/citusdata/stylechecker"
style_checker_tools_version: "0.8.33"
sql_snapshot_pg_version: "18.6"
image_suffix: "-va0a5582"
pg17_version: '{ "major": "17", "full": "17.11" }'
pg18_version: '{ "major": "18", "full": "18.6" }'
pg19_version: '{ "major": "19", "full": "19rc1" }'
upgrade_pg_versions: "17.11-18.6-19rc1"
sql_snapshot_pg_version: "18.7"
image_suffix: "-dev-5f24c0d"
pg17_version: '{ "major": "17", "full": "17.12" }'
pg18_version: '{ "major": "18", "full": "18.7" }'
pg19_version: '{ "major": "19", "full": "19.0" }'
upgrade_pg_versions: "17.12-18.7-19.0"
steps:
# Since GHA jobs need at least one step we use a noop step here.
- name: Set up parameters
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly_arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
name: Initialize parameters
runs-on: ubuntu-24.04
outputs:
pg_versions: '[{ "major": "17", "full": "17.11" }, { "major": "18", "full": "18.6" }]'
pg_versions: '[{ "major": "17", "full": "17.12" }, { "major": "18", "full": "18.7" }]'
steps:
- name: Set up parameters
run: echo 'noop'
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/nightly_cassert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ run-name: Nightly cassert (${{ github.ref_name }})
# asserts surface -- that is the intended signal, not a regression gate.
#
# The version matrix lives in the `params` job below (single source of truth, mirroring
# build_and_test.yml's params job, which pins 17.11 / 18.6 / 19rc1 and no longer builds PG16).
# build_and_test.yml's params job, which pins 17.12 / 18.7 / 19.0 and no longer builds PG16).

on:
schedule:
Expand All @@ -34,9 +34,9 @@ jobs:
name: Initialize parameters
runs-on: ubuntu-24.04
outputs:
pg_versions: '[{ "major": "17", "full": "17.11" }, { "major": "18", "full": "18.6" }, { "major": "19", "full": "19rc1" }]'
pg_upgrade_pairs: '[{ "old": "17", "old_full": "17.11", "new": "18", "new_full": "18.6" }, { "old": "18", "old_full": "18.6", "new": "19", "new_full": "19rc1" }, { "old": "17", "old_full": "17.11", "new": "19", "new_full": "19rc1" }]'
citus_upgrade_pg: '[{ "major": "17", "full": "17.11" }, { "major": "18", "full": "18.6" }]'
pg_versions: '[{ "major": "17", "full": "17.12" }, { "major": "18", "full": "18.7" }, { "major": "19", "full": "19.0" }]'
pg_upgrade_pairs: '[{ "old": "17", "old_full": "17.12", "new": "18", "new_full": "18.7" }, { "old": "18", "old_full": "18.7", "new": "19", "new_full": "19.0" }, { "old": "17", "old_full": "17.12", "new": "19", "new_full": "19.0" }]'
citus_upgrade_pg: '[{ "major": "17", "full": "17.12" }, { "major": "18", "full": "18.7" }]'
citus_old_version: "v14.0.1" # 14.0-1 chains to MASTER (15.0); 14.1 has no path to 15.0 yet
steps:
- name: Set up parameters
Expand Down
10 changes: 8 additions & 2 deletions src/backend/distributed/planner/deparse_shard_query.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@

static void UpdateTaskQueryString(Query *query, Task *task);
static RelationShard * FindRelationShard(Oid inputRelationId, List *relationShardList);
static void ConvertRteToSubqueryWithEmptyResult(RangeTblEntry *rte);
static bool ShouldLazyDeparseQuery(Task *task);
static char * DeparseTaskQuery(Task *task, Query *query);

Expand Down Expand Up @@ -573,7 +572,7 @@ FindRelationShard(Oid inputRelationId, List *relationShardList)
* ConvertRteToSubqueryWithEmptyResult converts given relation RTE into
* subquery RTE that returns no results.
*/
static void
void
ConvertRteToSubqueryWithEmptyResult(RangeTblEntry *rte)
{
Relation relation = table_open(rte->relid, NoLock);
Expand Down Expand Up @@ -620,6 +619,13 @@ ConvertRteToSubqueryWithEmptyResult(RangeTblEntry *rte)

rte->rtekind = RTE_SUBQUERY;

/*
* Table references normally have inh set even when they have no children.
* This replacement is an ordinary empty subquery, not an append relation.
* Clear the table's flag so later planning does not mistake it for one.
*/
rte->inh = false;

/* no permission checking for this RTE */
rte->perminfoindex = 0;

Expand Down
Loading
Loading