Skip to content

PG19: columnar CREATE INDEX fails (parallel-scan callbacks + serialization) #8611

Closed

Description

Part of the PG19 support umbrella: #8597.

On PG19, CREATE INDEX on a columnar table aborts with
ERROR: columnar_parallelscan_estimate not implemented. Two fixes to the
columnar TableAM, both required to get CREATE INDEX working on PG19.

1. Provide working parallel-scan callbacks

PG19's parallel btree index-build path unconditionally calls the
TableAM's parallelscan_estimate / parallelscan_initialize callbacks
even when the scan runs serially. Columnar's callbacks elog(ERROR).
Delegate to the heap-block helpers; columnar still never reads the
parallel-scan descriptor, so any state written is simply unused.

2. Serialize CREATE INDEX on columnar tables

PG19 can issue concurrent index builds against the same columnar
relation; stripe-write metadata is not safe for concurrent writers. Take
a per-relation lock during columnar index builds on PG19, only when the
build is against a columnar AM (heap index builds unaffected).

Validation

PG17.10 / PG18.4 / PG19devel build green under -Werror; on PG19
CREATE INDEX on columnar tables succeeds and concurrent builds
serialize cleanly. PG17/18 regression-neutral (callbacks were
elog(ERROR) and never reached there).

Plan detail: pg19-pr-plan/03-columnar-parallel-and-index.md (PR3).

Activity

  1. ihalatci commented on Jun 13, 2026

    @ihalatci
    ContributorAuthor

    CI improvement — PR #8618

    PR #8618 serializes CREATE INDEX on columnar tables for PG19 (parallel-scan
    callback + serialization fix). Measured against the PG19 baseline from #8616:

    • check-columnar / PG19: 8 → 7 failing tests — fixes columnar_create.

    check-style is green. check-columnar-isolation is flat (unrelated to this fix).
    Remaining columnar failures are tracked separately by #8619 and the remaining
    columnar items. PG16/PG17 unaffected (changes guarded by PG19).

  2. added a commit that references this issue on Jun 18, 2026
    c70d228
  3. added a commit that references this issue on Jun 26, 2026
    1ef844c
  4. ihalatci commented on Jun 26, 2026

    @ihalatci
    ContributorAuthor

    Resolved by #8618, which merged into the pg19-support integration branch (merge commit 1ef844c) on 2026-06-26.

    Note: GitHub did not auto-close this issue because #8618 merged into pg19-support (the PG19 integration branch), not the repository default branch (main). Closing keywords only fire on merges to the default branch, so PG19 stack tracking issues are closed manually as each PR lands. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions