Feature/con 569#385
Feature/con 569#385robertcli wants to merge 26 commits intocinchapi:developfrom robertcli:feature/CON-569
Conversation
This reverts commit 4712d42.
jtnelson
left a comment
jtnelson
left a comment
There was a problem hiding this comment.
@robertcli You should reset the autogenerated changes to ConcourseNavigateService and ConcourseCalculateService since those are strictly formatting differences.
You should also add some unit tests.
|
|
||
| Table<String, RegistryData, Object> reg = registry; | ||
|
|
||
| public Map<String, Set<String>> getPlugins() { |
There was a problem hiding this comment.
@robertcli You should name this method describePlugins so that is is more semantically clear as to what the method is actually doing
There was a problem hiding this comment.
Also reverted ConcourseNavigateService and ConcourseCalculateService to a previous commit to fix formatting changes.
| import java.lang.management.MemoryUsage; | ||
| import java.net.ServerSocket; | ||
| import java.nio.ByteBuffer; | ||
| import java.util.Hashtable; |
There was a problem hiding this comment.
This import is not being used, so remove it
There was a problem hiding this comment.
done. I guess for this to have pushed my spotlessApply didn't run correctly?
| } | ||
| } | ||
| }); | ||
| return temp; |
There was a problem hiding this comment.
Rename this variable to something more descriptive. Perhaps you can call it descriptions or something
|
|
||
| @Test | ||
| public void testInspect() { | ||
| Map<String, Set<String>> describe = client.inspect(); |
There was a problem hiding this comment.
@robertcli this test isn't asserting anything? How do you know its correct?
|
|
||
| import com.cinchapi.concourse.test.ConcourseIntegrationTest; | ||
|
|
||
| public class InspectTest extends ConcourseIntegrationTest { |
There was a problem hiding this comment.
This test should extend PluginTest and be included in the concourse-ete-tests- project.
Take a look at how the plugin tests are setup in the concourse-plugin-test-core project. You need to create some test plugins (similar to the TestPlugin class) and install them within the test.
2 participants
Please review this