Repository navigation
refactor: apply the Go 1.27 go fix modernizers - #112
Merged
Merged
Conversation
Mechanical rewrites from go fix on 1.27, behaviour unchanged: errors.AsType for errors.As, strings.Cut for IndexByte slicing, strings.SplitSeq for ranging over Split, maps.Copy for header copy loops, atomic.Int32/Int64 types in tests, and min in a test helper. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs
go fix ./...(Go 1.27) over both modules and keeps everything it suggests. All are behavior-preserving rewrites to current idiom:errors.As(err, &v)→errors.AsType[T](err)transport.go(isRetriable),acls_grant_test.gostrings.IndexByte+ slice →strings.Cuttransport.go(stripping the query from the signing path)strings.Split→strings.SplitSeqchefignore.go(no intermediate slice)maps.Copytransport.go,integration/suite/raw.goatomic.AddInt64(&n)→atomic.Int64cookbooks_test.go,transport_test.gominsearch_test.goNo public API change.
Test plan
go test ./... -race -count=2cleancd integration && go test ./...passes (HTTP and TLS targets)golangci-lint run ./...clean in both modules