Skip to content

feat(EventDismiss): accept and use lamps from Genie/Count Check#458

Merged
chsami merged 3 commits into
chsami:developmentfrom
runsonmypc:feature/event-handler-lamp
May 29, 2026
Merged

feat(EventDismiss): accept and use lamps from Genie/Count Check#458
chsami merged 3 commits into
chsami:developmentfrom
runsonmypc:feature/event-handler-lamp

Conversation

@runsonmypc
Copy link
Copy Markdown
Contributor

@runsonmypc runsonmypc commented May 26, 2026

Summary

  • Extends the Event Dismiss plugin to optionally accept lamps from Genie and Count Check instead of dismissing them
  • Handles full dialogue, waits for the lamp, then uses it on a configurable skill via the lamp interface (widget group 240)
  • Adds a minimal overlay showing lamp skill, usage count, and last lamp time (only visible when lamp features are active)
  • Adds a "Use Stray Lamps" option to automatically use lamps found in inventory from any source
  • Widget IDs verified live against the current lamp interface (Sailing skill was added since the original code)

Test plan

  • Enable plugin, set Genie to Accept, configure lamp skill
  • Encounter a Genie random event while a script is running — verify it talks to the genie, receives lamp, and uses it on the configured skill
  • Verify Count Check accept flow works the same way
  • Set Genie/Count Check to Dismiss — verify they are dismissed normally
  • Enable "Use Stray Lamps" with a lamp already in inventory while a script is running — verify it is used automatically
  • Verify the overlay only appears when at least one lamp feature is active
  • Verify other scripts resume normally after lamp usage completes

Extends the Event Dismiss plugin to optionally accept lamps from Genie
and Count Check instead of dismissing them. Handles the full dialogue,
waits for the lamp to appear, then uses it on a configurable skill.

Adds a minimal overlay showing lamp skill, usage count, and last lamp
time (only visible when lamp features are active). Also adds a "Use
Stray Lamps" option to automatically use lamps from any source.

Version bumped to 1.1.0.
Sailing (child 7) was added to the lamp interface since the recovered
code was written, shifting every skill from Hitpoints onward up by one
and moving the confirm button from child 26 to 27. Verified live
against widget group 240.
Breaking config change: boolean dismiss toggles replaced with
EventAction enums (Accept/Dismiss).
@runsonmypc runsonmypc force-pushed the feature/event-handler-lamp branch from b070ca4 to a7b81d0 Compare May 26, 2026 22:11
@chsami chsami merged commit 00b0763 into chsami:development May 29, 2026
1 check passed
@runsonmypc runsonmypc deleted the feature/event-handler-lamp branch May 30, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants