Fixes in libcef_dll: possible null dereference in ParseCommandLineArgs() and missed low surrogate is not handled in UTF16ToUTF8()#4219
Open
sergio-nsk wants to merge 3 commits into
Conversation
|
|
||
| // 3-byte UTF-8 standard fallback replacement characters. | ||
| // Lone low surrogate DE00. | ||
| EXPECT_EQ("\xEF\xBF\xBDcef", UTF16ToUTF8(u"\uDE00cef")); |
Collaborator
There was a problem hiding this comment.
\x escapes consume every following hexadecimal digit, so the c, e, and f suffix here is parsed as part of the final escape (\xBDcef). Clang rejects this with hex escape sequence out of range, which prevents ceftests from compiling. Please terminate the escape with an adjacent literal: "\xEF\xBF\xBD" "cef".
Contributor
Author
There was a problem hiding this comment.
Ha, I missed that what is done on the previous line. If you don't mind I make it "\xEF\xBF\xBDz" otherwise it gets an ugly format
EXPECT_EQ(
"\xEF\xBF\xBD"
"cef",
UTF16ToUTF8(u"\uDE00"
u"cef"));
sergio-nsk
force-pushed
the
sergio-nsk/fixes/1
branch
from
July 22, 2026 01:57
103a3a6 to
1e26ba4
Compare
sergio-nsk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.