Leave interpreting attribute values to the renderer#35
Open
slaskis wants to merge 3 commits intochoojs:masterfrom
Open
Leave interpreting attribute values to the renderer#35slaskis wants to merge 3 commits intochoojs:masterfrom
slaskis wants to merge 3 commits intochoojs:masterfrom
Conversation
Collaborator
Author
|
Because of the potentially breaking changes I'm thinking this might need a semver bump to 3.x.x |
|
Hi @substack @JamesKyburz 👋 Do you have any plans to merge this? |
|
This is a pretty major issue in hyperx in my opinion. |
|
I think if you pass a plain object to the tag it passes it on to the renderer. Your example would be rewritten as: <div ${{x: null}}></div>Or a full example from something I was working on recently (notice the const hx = require('hyperx')(require('virtual-dom/h'))
module.exports = ({changeHandler, label, options, selected}) => {
return hx`
<div>
<label>${label}
<select onchange=${changeHandler}>
${options.map((option) => hx`
<option
value=${option.id}
${{selected: selected.id === option.id}}
>
${option.name}
</option>`
)}
</select>
</label>
</div>`
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for #27 which changes the default behaviour of attribute values.
Now it will leave the interpreting of the attribute values to the renderer, such like
<div x=${null}></div>will pass attributes as{x: null}to the renderer instead of{x: 'null'}as it does before this PR.An important note may be that
nullandundefinedas values, with virtual-dom (^2.1.1), removes the attribute entirely, whilefalseinstead throws an exception because it attempts to do some entity serialization.Behaviour is different using hyperscript which simply makes an attribute with an empty string value instead.