Skip to content

#240 Made Wire receiveFrom stopMaster() optional - #459

Open
majenkotech wants to merge 1 commit into
chipKIT32:masterfrom
majenkotech:240-requestFrom
Open

#240 Made Wire receiveFrom stopMaster() optional#459
majenkotech wants to merge 1 commit into
chipKIT32:masterfrom
majenkotech:240-requestFrom

Conversation

@majenkotech

Copy link
Copy Markdown
Member

This adds an optional boolean parameter to Wire.requestFrom() which then is used to wrap the di2c.stopMaster() call to make executing it optional.

@majenkotech

Copy link
Copy Markdown
Member Author

BEFORE MERGING THIS NEEDS TESTING BY SOMEONE WITH A SUITABLE SETUP

I don't have a setup that needs this functionality at the moment and can't test the knock-on effect of it. If someone that has a setup that would use this parameter could test it before merging that would be a huge benefit.

@majenkotech

Copy link
Copy Markdown
Member Author

Potential fix for issue #240

@EmbeddedMan

Copy link
Copy Markdown
Member

What is required to test that this change works? Generating a request to an I2C slave in multiple parts without a stop in between each requestFrom() except the last?

@majenkotech

Copy link
Copy Markdown
Member Author

Yeah, with some device that expects to work that way.

@EmbeddedMan

Copy link
Copy Markdown
Member

If such a device can be identified, I may be able to test.

@majenkotech

Copy link
Copy Markdown
Member Author

I have a feeling things like EEPROMS may work this way. First set an address, then read from that address without restarting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants